* cciss kexec reset_devices commit
@ 2009-02-27 0:10 Randy Dunlap
2009-02-27 7:03 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2009-02-27 0:10 UTC (permalink / raw)
To: scsi; +Cc: Jens Axboe, Mike Miller
Was commit 5e4c91c84b194b26cf592779e451f4b5be777cba supposed to remove
the unconditional 30-second delay and replace it with a timeout loop?
What I see now (in source code) is the 30-second delay followed by
30 1-second retries...???
schedule_timeout_uninterruptible(30*HZ);
/* Now try to get the controller to respond to a no-op */
- for (i=0; i<12; i++) {
+ for (i=0; i<30; i++) {
if (cciss_noop(pdev) == 0)
break;
- else
- printk("cciss: no-op failed%s\n", (i < 11 ? "; re-trying" : ""));
+
+ schedule_timeout_uninterruptible(HZ);
+ }
+ if (i == 30) {
+ printk(KERN_ERR "cciss: controller seems dead\n");
+ return -EBUSY;
}
}
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: cciss kexec reset_devices commit
2009-02-27 0:10 cciss kexec reset_devices commit Randy Dunlap
@ 2009-02-27 7:03 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2009-02-27 7:03 UTC (permalink / raw)
To: Randy Dunlap; +Cc: scsi, Mike Miller
On Thu, Feb 26 2009, Randy Dunlap wrote:
> Was commit 5e4c91c84b194b26cf592779e451f4b5be777cba supposed to remove
> the unconditional 30-second delay and replace it with a timeout loop?
>
> What I see now (in source code) is the 30-second delay followed by
> 30 1-second retries...???
>
>
> schedule_timeout_uninterruptible(30*HZ);
>
> /* Now try to get the controller to respond to a no-op */
> - for (i=0; i<12; i++) {
> + for (i=0; i<30; i++) {
> if (cciss_noop(pdev) == 0)
> break;
> - else
> - printk("cciss: no-op failed%s\n", (i < 11 ? "; re-trying" : ""));
> +
> + schedule_timeout_uninterruptible(HZ);
> + }
> + if (i == 30) {
> + printk(KERN_ERR "cciss: controller seems dead\n");
> + return -EBUSY;
> }
> }
Good catch Randy, that first sleep should have gone away of course. I'll
kill it.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-27 7:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-27 0:10 cciss kexec reset_devices commit Randy Dunlap
2009-02-27 7:03 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.