[PATCH] make install on windows

[PATCH] make install on windows

[Alexandre Bique]

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

Hi,

On windows with cygwin or mingw, when i do make install, it installs
linux elf32 files instead of windows *.exe.

Here is a patch to install the right file depending on $(EXEEXT).

Thank you.

-- 
Alexandre Bique

[-- Attachment #2: grub2-r2001-make-install-win32.patch --]
[-- Type: application/octet-stream, Size: 1098 bytes --]

Index: Makefile.in
===================================================================
--- Makefile.in	(revision 2001)
+++ Makefile.in	(working copy)
@@ -222,14 +222,14 @@
 	  $(INSTALL_DATA) $$dir$$file $(DESTDIR)$(pkgdatadir)/$$dest; \
 	done
 	$(mkinstalldirs) $(DESTDIR)$(bindir) $(DESTDIR)$(mandir)/man1
-	@list='$(bin_UTILITIES)'; for file in $$list; do \
+	@list='$(bin_UTILITIES:=$(EXEEXT))'; for file in $$list; do \
 	  if test -f "$$file"; then dir=; else dir="$(srcdir)/"; fi; \
 	  dest="`echo $$file | sed 's,.*/,,' | sed '$(transform)'`"; \
 	  $(INSTALL_PROGRAM) $$dir$$file $(DESTDIR)$(bindir)/$$dest; \
 	  $(HELP2MAN) --section=1 $(builddir)/$$file > $(DESTDIR)$(mandir)/man1/$$dest.1; \
 	done
 	$(mkinstalldirs) $(DESTDIR)$(sbindir) $(DESTDIR)$(mandir)/man8
-	@list='$(sbin_UTILITIES)'; for file in $$list; do \
+	@list='$(sbin_UTILITIES:=$(EXEXT))'; for file in $$list; do \
 	  if test -f "$$file"; then dir=; else dir="$(srcdir)/"; fi; \
 	  dest="`echo $$file | sed 's,.*/,,' | sed '$(transform)'`"; \
 	  $(INSTALL_PROGRAM) $$dir$$file $(DESTDIR)$(sbindir)/$$dest; \

Re: [PATCH] make install on windows

[Alexandre Bique]

[-- Attachment #1: Type: text/plain, Size: 415 bytes --]

On Thu, Feb 26, 2009 at 4:40 PM, Alexandre Bique
<bique.alexandre@gmail.com> wrote:
> Hi,
>
> On windows with cygwin or mingw, when i do make install, it installs
> linux elf32 files instead of windows *.exe.
>
> Here is a patch to install the right file depending on $(EXEEXT).
>
> Thank you.

Ooouuuppss, there is a little mistake : $(EXEXT) instead of $(EXEEXT).
Take the new patch.

Sorry.

-- 
Alexandre Bique

[-- Attachment #2: grub2-r2001-make-install-win32-2.patch --]
[-- Type: application/octet-stream, Size: 1099 bytes --]

Index: Makefile.in
===================================================================
--- Makefile.in	(revision 2001)
+++ Makefile.in	(working copy)
@@ -222,14 +222,14 @@
 	  $(INSTALL_DATA) $$dir$$file $(DESTDIR)$(pkgdatadir)/$$dest; \
 	done
 	$(mkinstalldirs) $(DESTDIR)$(bindir) $(DESTDIR)$(mandir)/man1
-	@list='$(bin_UTILITIES)'; for file in $$list; do \
+	@list='$(bin_UTILITIES:=$(EXEEXT))'; for file in $$list; do \
 	  if test -f "$$file"; then dir=; else dir="$(srcdir)/"; fi; \
 	  dest="`echo $$file | sed 's,.*/,,' | sed '$(transform)'`"; \
 	  $(INSTALL_PROGRAM) $$dir$$file $(DESTDIR)$(bindir)/$$dest; \
 	  $(HELP2MAN) --section=1 $(builddir)/$$file > $(DESTDIR)$(mandir)/man1/$$dest.1; \
 	done
 	$(mkinstalldirs) $(DESTDIR)$(sbindir) $(DESTDIR)$(mandir)/man8
-	@list='$(sbin_UTILITIES)'; for file in $$list; do \
+	@list='$(sbin_UTILITIES:=$(EXEEXT))'; for file in $$list; do \
 	  if test -f "$$file"; then dir=; else dir="$(srcdir)/"; fi; \
 	  dest="`echo $$file | sed 's,.*/,,' | sed '$(transform)'`"; \
 	  $(INSTALL_PROGRAM) $$dir$$file $(DESTDIR)$(sbindir)/$$dest; \

Re: [PATCH] make install on windows

[Christian Franke]

Alexandre Bique wrote:
>   
>> Hi,
>>
>> On windows with cygwin or mingw, when i do make install, it installs
>> linux elf32 files instead of windows *.exe.
>>
>> Here is a patch to install the right file depending on $(EXEEXT).
>>
>> Thank you.
>>     
>
> Ooouuuppss, there is a little mistake : $(EXEXT) instead of $(EXEEXT).
> Take the new patch.
>
>   

> --- Makefile.in    (revision 2001)
> +++ Makefile.in    (working copy)
> @@ -222,14 +222,14 @@
>        $(INSTALL_DATA) $$dir$$file $(DESTDIR)$(pkgdatadir)/$$dest; \
>      done
>      $(mkinstalldirs) $(DESTDIR)$(bindir) $(DESTDIR)$(mandir)/man1
> -    @list='$(bin_UTILITIES)'; for file in $$list; do \
> +    @list='$(bin_UTILITIES:=$(EXEEXT))'; for file in $$list; do \
>        if test -f "$$file"; then dir=; else dir="$(srcdir)/"; fi; \
>        dest="`echo $$file | sed 's,.*/,,' | sed '$(transform)'`"; \

This is not necessary on Cygwin. Its /usr/bin/install handles the .exe 
issue itself, such that most existing Makefiles work OOTB.

Please make sure that /usr/bin/install and no other install is found in 
the PATH.

-- 
Christian Franke

Re: [PATCH] make install on windows

[Alexandre Bique]

On Sat, Feb 28, 2009 at 12:32 AM, Christian Franke
<Christian.Franke@t-online.de> wrote:
>
> Alexandre Bique wrote:
>>
>>
>>>
>>> Hi,
>>>
>>> On windows with cygwin or mingw, when i do make install, it installs
>>> linux elf32 files instead of windows *.exe.
>>>
>>> Here is a patch to install the right file depending on $(EXEEXT).
>>>
>>> Thank you.
>>>
>>
>> Ooouuuppss, there is a little mistake : $(EXEXT) instead of $(EXEEXT).
>> Take the new patch.
>>
>>
>
>> --- Makefile.in    (revision 2001)
>> +++ Makefile.in    (working copy)
>> @@ -222,14 +222,14 @@
>>       $(INSTALL_DATA) $$dir$$file $(DESTDIR)$(pkgdatadir)/$$dest; \
>>     done
>>     $(mkinstalldirs) $(DESTDIR)$(bindir) $(DESTDIR)$(mandir)/man1
>> -    @list='$(bin_UTILITIES)'; for file in $$list; do \
>> +    @list='$(bin_UTILITIES:=$(EXEEXT))'; for file in $$list; do \
>>       if test -f "$$file"; then dir=; else dir="$(srcdir)/"; fi; \
>>       dest="`echo $$file | sed 's,.*/,,' | sed '$(transform)'`"; \
>
> This is not necessary on Cygwin. Its /usr/bin/install handles the .exe issue itself, such that most existing Makefiles work OOTB.
>
> Please make sure that /usr/bin/install and no other install is found in the PATH.

Ok i will check it tomorow or monday.

--
Alexandre Bique