From: phcoder <phcoder@gmail.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Possible improvements to build system
Date: Sat, 28 Feb 2009 12:14:26 +0100 [thread overview]
Message-ID: <49A91C92.2030708@gmail.com> (raw)
Hello, I noticed that updating some pieces of code needs modification of
nearly all *.rmk. IMO it's bad thing because e.g. it easily brings
different architectures out of sync. My improvement propositions:
1. normal.mod
There is one part which is CPU-dependent - setjmp.S. t's used only in
static grub_err_t
rescue_command (struct grub_arg_list *state __attribute__ ((unused)),
int argc __attribute__ ((unused)),
char **args __attribute__ ((unused)))
{
grub_longjmp (grub_exit_env, 0);
/* Never reach here. */
return 0;
}
We could replace this longjmp by a call of grub_enter_rescue_mode and
move the call to attempt_normal_mode to grub_main.
Another possibility is to create a symlink normal/cpu during configure
time and then during build time just use normal/cpu/setjmp.S
2. ata.mod, hdparm.mod, ata_pthru.mod, usbms.mod, ohci.mod, uhci.mod,
usbtest.mod, usb.mod, memdisk.mod
I don't see why these modules are in i386-pc.rmk and not in common.rmk
3. kernel.img, grub-setup
These contain a number of files shared by all platforms. Like e.g.
filesystems. I propose to create an additional file common-pre.rmk which
could contain the variables like
FS_files=...
which platform-specific files can use later
--
Regards
Vladimir 'phcoder' Serbinenko
next reply other threads:[~2009-02-28 11:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-28 11:14 phcoder [this message]
2009-02-28 11:50 ` Possible improvements to build system Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49A91C92.2030708@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.