[Ocfs2-devel] Patch to move ocfs2_slot_info to slot_map.h

[Ocfs2-devel] Patch to move ocfs2_slot_info to slot_map.h

[Srinivas Eeda]

Next 3 patches does the following
1) movies ocfs2_slot_info struct from slot_map.c to slot_map.h
2) patch to recover orphans during mount even if the journal is clean
3) patch to recovery orphans in offline slots

[Ocfs2-devel] [PATCH 1/1] Patch to move ocfs2_slot_info to slot_map.h

[Srinivas Eeda]

This patch is required to access slot_info struct for a patch that recovers
orphans from offline slots.

Signed-off-by: Srinivas Eeda <srinivas.eeda@oracle.com>
---
 fs/ocfs2/slot_map.c |   17 -----------------
 fs/ocfs2/slot_map.h |   15 +++++++++++++++
 2 files changed, 15 insertions(+), 17 deletions(-)

diff --git a/fs/ocfs2/slot_map.c b/fs/ocfs2/slot_map.c
index 40661e7..9f82a5f 100644
--- a/fs/ocfs2/slot_map.c
+++ b/fs/ocfs2/slot_map.c
@@ -42,23 +42,6 @@
 
 #include "buffer_head_io.h"
 
-
-struct ocfs2_slot {
-	int sl_valid;
-	unsigned int sl_node_num;
-};
-
-struct ocfs2_slot_info {
-	int si_extended;
-	int si_slots_per_block;
-	struct inode *si_inode;
-	unsigned int si_blocks;
-	struct buffer_head **si_bh;
-	unsigned int si_num_slots;
-	struct ocfs2_slot *si_slots;
-};
-
-
 static int __ocfs2_node_num_to_slot(struct ocfs2_slot_info *si,
 				    unsigned int node_num);
 
diff --git a/fs/ocfs2/slot_map.h b/fs/ocfs2/slot_map.h
index 601c95f..12afe24 100644
--- a/fs/ocfs2/slot_map.h
+++ b/fs/ocfs2/slot_map.h
@@ -27,6 +27,21 @@
 #ifndef SLOTMAP_H
 #define SLOTMAP_H
 
+struct ocfs2_slot {
+	int sl_valid;
+	unsigned int sl_node_num;
+};
+
+struct ocfs2_slot_info {
+	int si_extended;
+	int si_slots_per_block;
+	struct inode *si_inode;
+	unsigned int si_blocks;
+	struct buffer_head **si_bh;
+	unsigned int si_num_slots;
+	struct ocfs2_slot *si_slots;
+};
+
 int ocfs2_init_slot_info(struct ocfs2_super *osb);
 void ocfs2_free_slot_info(struct ocfs2_super *osb);
 
-- 
1.5.6.5

[Ocfs2-devel] [PATCH 1/1] Patch to move ocfs2_slot_info to slot_map.h

[Joel Becker]

On Fri, Feb 27, 2009 at 06:00:54PM -0800, Srinivas Eeda wrote:
> This patch is required to access slot_info struct for a patch that recovers
> orphans from offline slots.

	Looking at your later code, it really looks like you need a set
of accessor functions.  There's no reason to expose slot_info in the
header.

Joel

-- 

"You must remember this:
 A kiss is just a kiss,
 A sigh is just a sigh.
 The fundamental rules apply
 As time goes by."

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127

[Ocfs2-devel] Patch to move ocfs2_slot_info to slot_map.h

[Tao Ma]

Hi Srini,
	could you please use git-format-patch -n next time to generate the 
patch set? It would make the patches have title like [1/3], [2/3]... So 
that it is easy for readers to read from the beginning. Thanks.

Regards,
Tao

Srinivas Eeda wrote:
> Next 3 patches does the following
> 1) movies ocfs2_slot_info struct from slot_map.c to slot_map.h
> 2) patch to recover orphans during mount even if the journal is clean
> 3) patch to recovery orphans in offline slots
> 
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> http://oss.oracle.com/mailman/listinfo/ocfs2-devel