Re: [PATCH 1/2] Input: Accelerated touchscreen support for Marvell Zylonite

[Jiri Slaby <jirislaby@gmail.com>]

On 2.3.2009 15:00, Mark Brown wrote:
> On Mon, Mar 02, 2009 at 02:44:28PM +0100, Jiri Slaby wrote:
>> On 2.3.2009 14:23, Mark Brown wrote:
>>> +	int count = 16;
>>> +	schedule_timeout_uninterruptible(1);
[...]
>>> +	while (count<   16) {
>
>> Weird condition.
>> + conding style
>
> Hrm.  This appears to have been mangled somewhere in the mail path to
> you - the indentation is normal in my send-mail folder and in the copy I
> got back from the list.

OK, anyway the condition looks weird on a semantic layer.

>>> +static void wm97xx_irq_enable(struct wm97xx *wm, int enable)
>>> +{
>>> +	if (enable)
>>> +		enable_irq(wm->pen_irq);
>>> +	else
>>> +		disable_irq(wm->pen_irq);
>
>> sync?
>
> Could you expand on this, please?

No, I was wrong, ignore this one. It's called from within the interrupt 
it disables.