From: Jiri Slaby <jirislaby@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Hans-Christian Egtvedt <hcegtvedt@atmel.com>
Subject: Re: [PATCH 2/2] Input: add wm97xx accelerated driver for AVR32 AT32AP700X microprocessors
Date: Mon, 02 Mar 2009 23:33:22 +0100 [thread overview]
Message-ID: <49AC5EB2.3050805@gmail.com> (raw)
In-Reply-To: <49ABEE83.904@gmail.com>
On 2.3.2009 15:34, Jiri Slaby wrote:
>> +static int at32_wm97xx_suspend(struct platform_device *pdev,
>> pm_message_t msg)
>> +{
>> + struct at32_wm97xx *at32_wm97xx = platform_get_drvdata(pdev);
>> +
>> + ac97c_writel(at32_wm97xx, IDR, AC97C_INT_CBEVT);
>> + disable_irq(at32_wm97xx->gpio_irq);
>
> Here, you should call disable_irq_sync() (that's what I meant by _sync
> in the last post).
Ah, it's in the opposite way. This one is fine, the patch 1/2 should use
disable_irq_nosync(), if I understand the code correctly.
next prev parent reply other threads:[~2009-03-02 22:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-02 13:23 [PATCH 1/2] Input: Accelerated touchscreen support for Marvell Zylonite Mark Brown
2009-03-02 13:23 ` [PATCH 2/2] Input: add wm97xx accelerated driver for AVR32 AT32AP700X microprocessors Mark Brown
2009-03-02 14:34 ` Jiri Slaby
2009-03-02 22:33 ` Jiri Slaby [this message]
2009-03-02 23:02 ` Mark Brown
2009-03-03 9:13 ` Dmitry Torokhov
2009-03-03 10:35 ` Mark Brown
2009-03-02 13:44 ` [PATCH 1/2] Input: Accelerated touchscreen support for Marvell Zylonite Jiri Slaby
2009-03-02 14:00 ` Mark Brown
2009-03-02 14:15 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49AC5EB2.3050805@gmail.com \
--to=jirislaby@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hcegtvedt@atmel.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.