From: Gabor Juhos <juhosg@openwrt.org>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH] ath9k: create a common debugfs_root for all device instances
Date: Thu, 05 Mar 2009 17:38:41 +0100 [thread overview]
Message-ID: <49B00011.1030001@openwrt.org> (raw)
In-Reply-To: <18863.64330.683644.463962@gargle.gargle.HOWL>
Sujith ?rta:
> Gabor Juhos wrote:
>> The driver are trying to create an 'ath9k' directory in debugfs for each
>> device currently. If there are more than one device in the system, the
>> second try will always fail.
>
> Looks good. Thanks.
Thank you for the review.
>
> Also, reading 'rcstat' when the interface is down would cause a NULL
> pointer dereference.
Indeed. :)
root at OpenWrt:/# cat /tmp/debug/ath9k/phy0/rcstat
CPU 0 Unable to handle kernel paging request at virtual address 00000000, epc ==
c02886c8, ra == c0288674
Oops[#1]:
Cpu 0
$ 0 : 00000000 fffffff8 00000000 00000000
$ 4 : ffffffff 00000200 c02a0000 00000005
$ 8 : 00000000 80000008 ffffffff 00000000
$12 : 82d8d080 00000000 2ab935ac 00404995
$16 : 00000017 82f30ae0 82f30ae0 00000000
$20 : 00000000 7fc3d130 00001000 82d9bf18
$24 : 00000166 c028853c
$28 : 82d9a000 82d9bab0 00000003 c0288674
Hi : 0000025b
Lo : 000001df
epc : c02886c8 0xc02886c8
Not tainted
ra : c0288674 0xc0288674
Status: 1000f403 KERNEL EXL IE
Cause : 00800008
BadVA : 00000000
PrId : 00019374 (MIPS 24Kc)
Modules linked in: leds_gpio nf_nat_tftp nf_conntrack_tftp nf_nat_irc
nf_conntrack_irc nf_nat_ftp nf_conntrack_ftp ipt_MASQUi
Process cat (pid: 852, threadinfo=82d9a000, task=82ddba18, tls=00000000)
Stack : 8027809c 00000000 c029b96c c029b974 83889f48 00000001 80278098 00000200
00000000 2aaed0d8 20202052 61746520 20202020 20205375 63636573 730a0a00
00000001 00000044 00000000 2aaed0d8 00000000 001200d2 81065c60 8284b2a8
82897528 82897528 00000001 00000200 81065c60 00000000 800bee0c 800bee0c
82897528 82897528 82e904b4 00000000 00000001 00000005 2aaed000 81065c60
...
> Will send out a patch fixing this.
Superb.
Gabor
WARNING: multiple messages have this Message-ID (diff)
From: Gabor Juhos <juhosg@openwrt.org>
To: Sujith <m.sujith@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
"ath9k-devel@lists.ath9k.org" <ath9k-devel@lists.ath9k.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [ath9k-devel] [PATCH] ath9k: create a common debugfs_root for all device instances
Date: Thu, 05 Mar 2009 17:38:41 +0100 [thread overview]
Message-ID: <49B00011.1030001@openwrt.org> (raw)
In-Reply-To: <18863.64330.683644.463962@gargle.gargle.HOWL>
Sujith =EDrta:
> Gabor Juhos wrote:
>> The driver are trying to create an 'ath9k' directory in debugfs for =
each
>> device currently. If there are more than one device in the system, t=
he
>> second try will always fail.
>=20
> Looks good. Thanks.
Thank you for the review.
>=20
> Also, reading 'rcstat' when the interface is down would cause a NULL
> pointer dereference.=20
Indeed. :)
root@OpenWrt:/# cat /tmp/debug/ath9k/phy0/rcstat
CPU 0 Unable to handle kernel paging request at virtual address 0000000=
0, epc =3D=3D
c02886c8, ra =3D=3D c0288674
Oops[#1]:
Cpu 0
$ 0 : 00000000 fffffff8 00000000 00000000
$ 4 : ffffffff 00000200 c02a0000 00000005
$ 8 : 00000000 80000008 ffffffff 00000000
$12 : 82d8d080 00000000 2ab935ac 00404995
$16 : 00000017 82f30ae0 82f30ae0 00000000
$20 : 00000000 7fc3d130 00001000 82d9bf18
$24 : 00000166 c028853c
$28 : 82d9a000 82d9bab0 00000003 c0288674
Hi : 0000025b
Lo : 000001df
epc : c02886c8 0xc02886c8
Not tainted
ra : c0288674 0xc0288674
Status: 1000f403 KERNEL EXL IE
Cause : 00800008
BadVA : 00000000
PrId : 00019374 (MIPS 24Kc)
Modules linked in: leds_gpio nf_nat_tftp nf_conntrack_tftp nf_nat_irc
nf_conntrack_irc nf_nat_ftp nf_conntrack_ftp ipt_MASQUi
Process cat (pid: 852, threadinfo=3D82d9a000, task=3D82ddba18, tls=3D00=
000000)
Stack : 8027809c 00000000 c029b96c c029b974 83889f48 00000001 80278098 =
00000200
00000000 2aaed0d8 20202052 61746520 20202020 20205375 63636573 =
730a0a00
00000001 00000044 00000000 2aaed0d8 00000000 001200d2 81065c60 =
8284b2a8
82897528 82897528 00000001 00000200 81065c60 00000000 800bee0c =
800bee0c
82897528 82897528 82e904b4 00000000 00000001 00000005 2aaed000 =
81065c60
...
> Will send out a patch fixing this.
Superb.
Gabor
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-03-05 16:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-05 15:55 [ath9k-devel] [PATCH] ath9k: create a common debugfs_root for all device instances Gabor Juhos
2009-03-05 15:55 ` Gabor Juhos
2009-03-05 16:18 ` [ath9k-devel] " Sujith
2009-03-05 16:18 ` Sujith
2009-03-05 16:38 ` Gabor Juhos [this message]
2009-03-05 16:38 ` Gabor Juhos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49B00011.1030001@openwrt.org \
--to=juhosg@openwrt.org \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.