All of lore.kernel.org
 help / color / mirror / Atom feed
* [Xenomai-core] [PATCH] Correct error handling in rtcan_ixxat_pci.c if card has wrong sub_sys_id
@ 2009-03-10 13:34 Sebastian Smolorz
  0 siblings, 0 replies; only message in thread
From: Sebastian Smolorz @ 2009-03-10 13:34 UTC (permalink / raw)
  To: xenomai-core

[-- Attachment #1: Type: text/plain, Size: 79 bytes --]

Hi,

the subject says it all. The patch is only compile-tested.

-- 
Sebastian

[-- Attachment #2: rtcan_ixxat_pci.patch --]
[-- Type: text/plain, Size: 695 bytes --]

Index: ksrc/drivers/can/sja1000/rtcan_ixxat_pci.c
===================================================================
--- ksrc/drivers/can/sja1000/rtcan_ixxat_pci.c	(Revision 4679)
+++ ksrc/drivers/can/sja1000/rtcan_ixxat_pci.c	(Arbeitskopie)
@@ -223,8 +223,10 @@ static int __devinit ixxat_pci_init_one 
     RTCAN_DBG("%s: Initializing device %04x:%04x:%04x\n",
 	      RTCAN_DRV_NAME, pdev->vendor, pdev->device, sub_sys_id);
 
-    if (sub_sys_id != IXXAT_PCI_SUB_SYS_ID)
-	    return -ENODEV;
+    if (sub_sys_id != IXXAT_PCI_SUB_SYS_ID) {
+	ret = -ENODEV;
+	goto failure_release_pci;
+    }
 
     /* Enable memory and I/O space */
     if ((ret = pci_write_config_word(pdev, 0x04, 0x3)))

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-03-10 13:34 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-10 13:34 [Xenomai-core] [PATCH] Correct error handling in rtcan_ixxat_pci.c if card has wrong sub_sys_id Sebastian Smolorz

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.