From: Tejun Heo <tj@kernel.org>
To: "Sachin P. Sant" <sachinp@in.ibm.com>
Cc: linux-next@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
linuxppc-dev@ozlabs.org, LKML <linux-kernel@vger.kernel.org>
Subject: [GIT PATCH tj-percpu] percpu: fix spurious alignment WARN in legacy SMP percpu allocator
Date: Wed, 11 Mar 2009 14:53:41 +0900 [thread overview]
Message-ID: <49B751E5.1060305@kernel.org> (raw)
In-Reply-To: <49B73B15.3040101@in.ibm.com>
Impact: remove spurious WARN on legacy SMP percpu allocator
Commit f2a8205c4ef1af917d175c36a4097ae5587791c8 incorrectly added too
tight WARN_ON_ONCE() on alignments for UP and legacy SMP percpu
allocator. Commit e317603694bfd17b28a40de9d65e1a4ec12f816e fixed it
for UP but legacy SMP allocator was forgotten. Fix it.
Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Sachin P. Sant <sachinp@in.ibm.com>
---
Oops, that was a stupid omission. This patch should fix it. Ingo,
please pull from the following git vector to receive the first first
four patches from the use-dynamic-percpu-allocator-by-default patchset
(without the actual conversion which can disrupt archs) + this patch.
I moved the actual conversion patch into #tj-percpu-exp branch, so the
pull should be safe.
git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git tj-percpu
Thanks.
mm/allocpercpu.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/mm/allocpercpu.c b/mm/allocpercpu.c
index 3653c57..1882923 100644
--- a/mm/allocpercpu.c
+++ b/mm/allocpercpu.c
@@ -120,7 +120,7 @@ void *__alloc_percpu(size_t size, size_t align)
* on it. Larger alignment should only be used for module
* percpu sections on SMP for which this path isn't used.
*/
- WARN_ON_ONCE(align > __alignof__(unsigned long long));
+ WARN_ON_ONCE(align > SMP_CACHE_BYTES);
if (unlikely(!pdata))
return NULL;
--
1.6.0.2
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: "Sachin P. Sant" <sachinp@in.ibm.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linuxppc-dev@ozlabs.org
Subject: [GIT PATCH tj-percpu] percpu: fix spurious alignment WARN in legacy SMP percpu allocator
Date: Wed, 11 Mar 2009 14:53:41 +0900 [thread overview]
Message-ID: <49B751E5.1060305@kernel.org> (raw)
In-Reply-To: <49B73B15.3040101@in.ibm.com>
Impact: remove spurious WARN on legacy SMP percpu allocator
Commit f2a8205c4ef1af917d175c36a4097ae5587791c8 incorrectly added too
tight WARN_ON_ONCE() on alignments for UP and legacy SMP percpu
allocator. Commit e317603694bfd17b28a40de9d65e1a4ec12f816e fixed it
for UP but legacy SMP allocator was forgotten. Fix it.
Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Sachin P. Sant <sachinp@in.ibm.com>
---
Oops, that was a stupid omission. This patch should fix it. Ingo,
please pull from the following git vector to receive the first first
four patches from the use-dynamic-percpu-allocator-by-default patchset
(without the actual conversion which can disrupt archs) + this patch.
I moved the actual conversion patch into #tj-percpu-exp branch, so the
pull should be safe.
git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git tj-percpu
Thanks.
mm/allocpercpu.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/mm/allocpercpu.c b/mm/allocpercpu.c
index 3653c57..1882923 100644
--- a/mm/allocpercpu.c
+++ b/mm/allocpercpu.c
@@ -120,7 +120,7 @@ void *__alloc_percpu(size_t size, size_t align)
* on it. Larger alignment should only be used for module
* percpu sections on SMP for which this path isn't used.
*/
- WARN_ON_ONCE(align > __alignof__(unsigned long long));
+ WARN_ON_ONCE(align > SMP_CACHE_BYTES);
if (unlikely(!pdata))
return NULL;
--
1.6.0.2
next prev parent reply other threads:[~2009-03-11 5:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-10 8:55 linux-next: Tree for March 10 Stephen Rothwell
2009-03-10 9:33 ` Wim Van Sebroeck
2009-03-10 11:07 ` Stephen Rothwell
2009-03-10 14:12 ` Next 10: Badness at mm/allocpercpu.c:123 Sachin P. Sant
2009-03-10 14:12 ` Sachin P. Sant
2009-03-11 4:16 ` Sachin P. Sant
2009-03-11 4:16 ` Sachin P. Sant
2009-03-11 5:53 ` Tejun Heo [this message]
2009-03-11 5:53 ` [GIT PATCH tj-percpu] percpu: fix spurious alignment WARN in legacy SMP percpu allocator Tejun Heo
2009-03-11 5:54 ` [RESEND GIT " Tejun Heo
2009-03-11 5:54 ` Tejun Heo
2009-03-11 6:48 ` Sachin P. Sant
2009-03-11 6:48 ` Sachin P. Sant
2009-03-11 9:31 ` Ingo Molnar
2009-03-11 9:31 ` Ingo Molnar
2009-03-11 8:50 ` Next 10: Badness at mm/allocpercpu.c:123 AA
2009-03-11 8:50 ` AA
2009-03-11 8:53 ` where should I map 0x8000,0000 ~ 0xfc00,0000 to ? AA
2009-03-11 8:53 ` AA
2009-03-10 18:57 ` linux-next: Tree for March 10 (crypto & NLATTR) Randy Dunlap
2009-03-10 19:56 ` Geert Uytterhoeven
2009-03-10 20:08 ` Randy Dunlap
2009-03-10 20:17 ` David Miller
2009-03-11 1:07 ` Herbert Xu
2009-03-11 12:25 ` Geert Uytterhoeven
2009-03-11 16:55 ` Randy Dunlap
2009-03-10 18:59 ` [PATCH -next] staging/p9auth: fix dependency/build error Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49B751E5.1060305@kernel.org \
--to=tj@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sachinp@in.ibm.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.