All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yang, Xiaowei" <xiaowei.yang@intel.com>
To: Jiri Denemark <jdenemar@redhat.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] xend: Fix removing /vm/UUID/device paths when device cannot be disconnected v2
Date: Fri, 13 Mar 2009 10:42:00 +0800	[thread overview]
Message-ID: <49B9C7F8.8010106@intel.com> (raw)
In-Reply-To: <49B9C000.3070805@intel.com>

> This is a corrected version of a patch commited as c/s 19250 and reverted by
> c/s 19314. Thanks to "trap sigerr ERR" in xen-hotplug-common.sh the
> xen-hotplug-cleanup would exit when reading /local/domain/ID/vm fails thus
> skipping all the xenstore-rm lines in the rest of the script. Sorry for the
> troubles the original patch caused...

Hi Jiri,
Did you also notice after claim_lock() returns, the ERR trap handler is 
still "sigerr" instead of the one registered inside claim_lock: 
"release_lock $1; sigerr"? I guess it only takes effect within the scope 
of a function. Can shell experts give an explanation here?:)

If so, claim_lock never works as it meant to be, and we will have 
potential issue as it's widely used.

Thanks,
xiaowei

       reply	other threads:[~2009-03-13  2:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <49B9C000.3070805@intel.com>
2009-03-13  2:42 ` Yang, Xiaowei [this message]
2009-03-12 14:24 [PATCH] xend: Fix removing /vm/UUID/device paths when device cannot be disconnected v2 Jiri Denemark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49B9C7F8.8010106@intel.com \
    --to=xiaowei.yang@intel.com \
    --cc=jdenemar@redhat.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.