From: David Newall <davidn@davidnewall.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Mike Galbraith <efault@gmx.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] (latest tip) make dequeue_task less confusing
Date: Fri, 13 Mar 2009 14:28:27 +1030 [thread overview]
Message-ID: <49B9D9E3.5080108@davidnewall.com> (raw)
In-Reply-To: <20090313004558.GD19544@elte.hu>
Ingo Molnar wrote:
> * David Newall <davidn@davidnewall.com> wrote:
>
>> No. On further consideration, I don't like my patch.
>>
>
> With the __dequeue_task()+inline suggestion i made i think it
> would be a micro-optimization and would not break symmetry in a
> significant way.
What I realised, upon closer examination, is that enqueue_task has the
same issue (with wakeup); and that the one places where sleep and wakeup
are set are in a single call for each, to (de|en)activate_task. If it
made sense to do what I suggested, then it should be done all the way,
that is, move the sleep and wakeup code to those two places, and
replicate the (admittedly smaller) *queue_task and *activate_task at
those points. This smacks of premature optimisation.
prev parent reply other threads:[~2009-03-13 3:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-12 8:56 [PATCH] (latest tip) make dequeue_task less confusing David Newall
2009-03-12 9:55 ` Ingo Molnar
2009-03-12 13:36 ` Mike Galbraith
2009-03-12 18:02 ` David Newall
2009-03-13 0:45 ` Ingo Molnar
2009-03-13 3:58 ` David Newall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49B9D9E3.5080108@davidnewall.com \
--to=davidn@davidnewall.com \
--cc=a.p.zijlstra@chello.nl \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.