From: Kalle Valo <kalle.valo@nokia.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "John W. Linville" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: don't drop null frames during software scan
Date: Sat, 14 Mar 2009 17:32:40 +0200 [thread overview]
Message-ID: <49BBCE18.4090606@nokia.com> (raw)
In-Reply-To: <1237043931.5235.67.camel@johannes.local>
Johannes Berg wrote:
> On Sat, 2009-03-14 at 16:44 +0200, Kalle Valo wrote:
>> ieee80211_tx_h_check_assoc() was dropping everything else than probe
>> requests during software scan. So the null frame with the power save
>> bit was dropped and AP never received it. This meant that AP never
>> buffered any frames for the station during software scan.
>>
>> Fix this by allowing to transmit both probe request and null frames
>> during software scan. Tested with stlc45xx.
>
> Would it make sense to reorder the scan code instead?
Perhaps. I chose this path only because it was simple to implement :)
I'll take a look at the scan code in more detail and fix it there.
Kalle
next prev parent reply other threads:[~2009-03-14 15:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-14 14:44 [PATCH] mac80211: don't drop null frames during software scan Kalle Valo
2009-03-14 15:18 ` Johannes Berg
2009-03-14 15:32 ` Kalle Valo [this message]
2009-03-14 16:07 ` Johannes Berg
2009-03-14 16:09 ` Johannes Berg
2009-03-14 17:04 ` Kalle Valo
2009-03-15 20:12 ` Kalle Valo
2009-03-14 16:12 ` Johannes Berg
2009-03-14 16:18 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49BBCE18.4090606@nokia.com \
--to=kalle.valo@nokia.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.