Re: [PATCH] mac80211: don't drop null frames during software scan

[Kalle Valo <kalle.valo@nokia.com>]

Johannes Berg wrote:
> On Sat, 2009-03-14 at 17:07 +0100, Johannes Berg wrote:
>> On Sat, 2009-03-14 at 17:32 +0200, Kalle Valo wrote:
>>> Perhaps. I chose this path only because it was simple to implement :) 
>>> I'll take a look at the scan code in more detail and fix it there.
>> You're kinda right too, we want to disable the queues first, then set
>> sw_scanning/notify the driver, and then send the nullfunc, I think. So
>> it's either this patch, or iterating the interface list twice.
> 
> Similarly for the beacon disable part, that _needs_ to be done after
> sw_scanning=true otherwise it won't actually work...
> 
> I think I prefer your patch over that complexity, but would like to have
> a good comment explaining it

Ok. I'll add a comment in v2.

> and possibly one in
> scan.c:ieee80211_start_scan that points to that code.

Yeah, that's definitely needed. I was first really confused why the null 
frame got lost.

Kalle