From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: kvm-devel <kvm@vger.kernel.org>
Subject: Re: [PATCH] kvm-userspace: x86: Support for breakpoints in ROM code
Date: Tue, 17 Mar 2009 11:33:41 +0200 [thread overview]
Message-ID: <49BF6E75.1070802@redhat.com> (raw)
In-Reply-To: <49BEA02A.1070909@siemens.com>
Jan Kiszka wrote:
> Jan Kiszka wrote:
>
>> Align qemu-kvm-x86 with upstream kvm support /wrt software breakpoint
>> support in ROM code.
>>
>
> Hmm, this might not be needed as kvm-userspace is not protecting its
> ROM. That's why I didn't pushed this so far. However, aligning isn't
> bad. But dropping this duplication would be better...
>
Aligning is a good thing (and duplication can be fixed in upstream and
merged here). But maybe cpu_memory_rw_debug() should use
cpu_physical_memory_write_rom() to write, instead of this hack?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-03-17 9:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-16 18:48 [PATCH] kvm-userspace: x86: Support for breakpoints in ROM code Jan Kiszka
2009-03-16 18:53 ` Jan Kiszka
2009-03-17 9:33 ` Avi Kivity [this message]
2009-03-17 9:44 ` Jan Kiszka
2009-03-17 9:51 ` Avi Kivity
2009-03-17 10:43 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49BF6E75.1070802@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.