All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jim Fehlig <jfehlig@novell.com>
To: xen-devel <xen-devel@lists.xensource.com>
Subject: [PATCH] (resend) Use vnc-listen setting specified in xend config file
Date: Tue, 17 Mar 2009 10:15:10 -0600	[thread overview]
Message-ID: <49BFCC8E.4030300@novell.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 648 bytes --]

My mailer botched original patch as it exceeded 80 columns - apologies.

If domU frame buffer configuration has no vnclisten attribute set, use
the global vnc-listen address specified in xend configuration file when
updating vfb location.  Currently the hardcoded value 'localhost' is used.

Example: User specifies (vnc-listen '192.168.0.1') in xend configuration
file and does not have vnclisten set in domU configuration.  Starting a
domU with this configuration results in vfb location containing

            (location localhost:5900)

instead of

            (location 192.168.0.1:5900)


    Signed-off-by: Jim Fehlig <jfehlig@novell.com>



[-- Attachment #2: xend-vnclisten.patch --]
[-- Type: text/x-patch, Size: 818 bytes --]

diff -r 0e1449d6f231 tools/python/xen/xend/XendDomainInfo.py
--- a/tools/python/xen/xend/XendDomainInfo.py	Fri Mar 13 10:09:25 2009 +0000
+++ b/tools/python/xen/xend/XendDomainInfo.py	Mon Mar 16 13:17:03 2009 -0600
@@ -1410,7 +1410,8 @@ class XendDomainInfo:
             for dev_uuid, (dev_type, dev_info) in self.info['devices'].items():
                 if dev_type == 'vfb':
                     old_location = dev_info.get('location')
-                    listen_host = dev_info.get('vnclisten', 'localhost')
+                    listen_host = dev_info.get('vnclisten', \
+                                XendOptions.instance().get_vnclisten_address())
                     new_location = '%s:%s' % (listen_host, str(vnc_port))
                     if old_location == new_location:
                         break

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

                 reply	other threads:[~2009-03-17 16:15 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49BFCC8E.4030300@novell.com \
    --to=jfehlig@novell.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.