* [PATCH] remove old backup file after renaming vg
@ 2009-03-19 15:52 Takahiro Yasui
2009-03-19 16:09 ` Alasdair G Kergon
0 siblings, 1 reply; 3+ messages in thread
From: Takahiro Yasui @ 2009-03-19 15:52 UTC (permalink / raw)
To: lvm-devel
Hi,
This patch removes an old backup file after renaming vg
by the vgrename command.
Regards,
---
Takahiro Yasui
Hitachi Computer Products (America), Inc.
Signed-off-by: Takahiro Yasui <tyasui@redhat.com>
---
tools/vgrename.c | 1 +
1 file changed, 1 insertion(+)
Index: LVM2.02.46-20090316/tools/vgrename.c
===================================================================
--- LVM2.02.46-20090316.orig/tools/vgrename.c
+++ LVM2.02.46-20090316/tools/vgrename.c
@@ -149,6 +149,7 @@ static int vg_rename_path(struct cmd_con
/******* FIXME Rename any active LVs! *****/
backup(vg);
+ backup_remove(cmd, vg_name_old);
unlock_vg(cmd, vg_name_new);
unlock_vg(cmd, vg_name_old);
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] remove old backup file after renaming vg
2009-03-19 15:52 [PATCH] remove old backup file after renaming vg Takahiro Yasui
@ 2009-03-19 16:09 ` Alasdair G Kergon
2009-03-19 16:40 ` Takahiro Yasui
0 siblings, 1 reply; 3+ messages in thread
From: Alasdair G Kergon @ 2009-03-19 16:09 UTC (permalink / raw)
To: lvm-devel
On Thu, Mar 19, 2009 at 11:52:21AM -0400, Takahiro Yasui wrote:
> This patch removes an old backup file after renaming vg
> by the vgrename command.
Ack provided that an archive file with identical contents already
got created.
Alasdair
--
agk at redhat.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] remove old backup file after renaming vg
2009-03-19 16:09 ` Alasdair G Kergon
@ 2009-03-19 16:40 ` Takahiro Yasui
0 siblings, 0 replies; 3+ messages in thread
From: Takahiro Yasui @ 2009-03-19 16:40 UTC (permalink / raw)
To: lvm-devel
Hi Alasdair,
> On Thu, Mar 19, 2009 at 11:52:21AM -0400, Takahiro Yasui wrote:
>> This patch removes an old backup file after renaming vg
>> by the vgrename command.
>
> Ack provided that an archive file with identical contents already
> got created.
Thank you for reviewing this patch.
Yes, an archive file with identical contents is created before actual
rename action by vg_rename function. The archive and backup sequence
of vg_rename_path function is
- archive old_vg
- rename old_vg to new_vg
- backup new_vg
- backup_remove old_vg
Thanks,
Taka
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-03-19 16:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-19 15:52 [PATCH] remove old backup file after renaming vg Takahiro Yasui
2009-03-19 16:09 ` Alasdair G Kergon
2009-03-19 16:40 ` Takahiro Yasui
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.