From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/3] vnc: throttle screen updates.
Date: Fri, 20 Mar 2009 09:37:46 +0100 [thread overview]
Message-ID: <49C355DA.8070504@redhat.com> (raw)
In-Reply-To: <49C28020.5060503@eu.citrix.com>
Stefano Stabellini wrote:
> I like the idea behind this patch, but I would make force_update an
> unsigned integer instead of a boolean, incrementing it every time we get a
> framebuffer_update_request and decrementing it every time we send a
> reply.
Point being?
Note that we can satisfy multiple update requests in one reply.
Also note that vnc_copy() sets force_update too.
> Secondly we could even move vga_hw_update after:
>
> if (vs->output.offset && !vs->audio_cap && !vs->force_update)
Agreed.
cheers,
Gerd
next prev parent reply other threads:[~2009-03-20 8:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-18 16:09 [Qemu-devel] [PATCH 3/3] vnc: throttle screen updates Gerd Hoffmann
2009-03-19 17:25 ` Stefano Stabellini
2009-03-20 8:37 ` Gerd Hoffmann [this message]
2009-03-20 10:14 ` Stefano Stabellini
-- strict thread matches above, loose matches on Subject: below --
2009-03-20 11:31 [Qemu-devel] [PATCH 0/3] vnc patches Gerd Hoffmann
2009-03-20 11:31 ` [Qemu-devel] [PATCH 3/3] vnc: throttle screen updates Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49C355DA.8070504@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.