[PATCH] Add powerpc signalfd syscall numbers

[PATCH] Add powerpc signalfd syscall numbers

[Matt Helsley]

Add signalfd and signalfd4 syscall number definitions for powerpc so
that we may compile even with older platform headers.

Signed-off-by: Matt Helsley <matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

diff --git a/src/lxc/start.c b/src/lxc/start.c
index 476d695..051e70c 100644
--- a/src/lxc/start.c
+++ b/src/lxc/start.c
@@ -51,6 +51,8 @@
 #      define __NR_signalfd4 327
 #    elif __x86_64__
 #      define __NR_signalfd4 289
+#    elif __powerpc__
+#      define __NR_signalfd4 313
 #    elif __s390x__
 #      define __NR_signalfd4 322
 #    endif
@@ -62,6 +64,8 @@
 #      define __NR_signalfd 321
 #    elif __x86_64__
 #      define __NR_signalfd 282
+#    elif __powerpc__
+#      define __NR_signalfd 305
 #    elif __s390x__
 #      define __NR_signalfd 316
 #    endif

Re: [PATCH] Add powerpc signalfd syscall numbers

[Matt Helsley]

Argh, forgot to mention it's a patch for liblxc and not a kernel patch!

Also I'm taking lxc-devel-TtF/mJH4Jtrk1uMJSBkQmQ@public.gmane.org off Cc since it seems to refuse email
from non-members.

On Thu, Mar 19, 2009 at 10:44:20PM -0700, Matt Helsley wrote:
> Add signalfd and signalfd4 syscall number definitions for powerpc so
> that we may compile even with older platform headers.
> 
> Signed-off-by: Matt Helsley <matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> 
> diff --git a/src/lxc/start.c b/src/lxc/start.c
> index 476d695..051e70c 100644
> --- a/src/lxc/start.c
> +++ b/src/lxc/start.c
> @@ -51,6 +51,8 @@
>  #      define __NR_signalfd4 327
>  #    elif __x86_64__
>  #      define __NR_signalfd4 289
> +#    elif __powerpc__
> +#      define __NR_signalfd4 313
>  #    elif __s390x__
>  #      define __NR_signalfd4 322
>  #    endif
> @@ -62,6 +64,8 @@
>  #      define __NR_signalfd 321
>  #    elif __x86_64__
>  #      define __NR_signalfd 282
> +#    elif __powerpc__
> +#      define __NR_signalfd 305
>  #    elif __s390x__
>  #      define __NR_signalfd 316
>  #    endif

As best I can tell the only other syscall nr definitions missing for
powerpc are the checkpoint/restart ones. I figured those were probably
left out intentionally so I did not add them.

Cheers,
	-Matt Helsley

Re: [PATCH] Add powerpc signalfd syscall numbers

[Daniel Lezcano]

Matt Helsley wrote:
> Argh, forgot to mention it's a patch for liblxc and not a kernel patch!
>
> Also I'm taking lxc-devel-TtF/mJH4Jtrk1uMJSBkQmQ@public.gmane.org off Cc since it seems to refuse email
> from non-members.
>   
I changed the option in mailman, that should be fixed.

Re: [PATCH] Add powerpc signalfd syscall numbers

[Eric W. Biederman]

Daniel Lezcano <daniel.lezcano-GANU6spQydw@public.gmane.org> writes:

> Matt Helsley wrote:
>> Argh, forgot to mention it's a patch for liblxc and not a kernel patch!
>>
>> Also I'm taking lxc-devel-TtF/mJH4Jtrk1uMJSBkQmQ@public.gmane.org off Cc since it seems to refuse email
>> from non-members.
>>   
> I changed the option in mailman, that should be fixed.

I thought lxc-devel was long past dead.

Eric

Re: [PATCH] Add powerpc signalfd syscall numbers

[Daniel Lezcano]

Eric W. Biederman wrote:
> Daniel Lezcano <daniel.lezcano-GANU6spQydw@public.gmane.org> writes:
>
>   
>> Matt Helsley wrote:
>>     
>>> Argh, forgot to mention it's a patch for liblxc and not a kernel patch!
>>>
>>> Also I'm taking lxc-devel-TtF/mJH4Jtrk1uMJSBkQmQ@public.gmane.org off Cc since it seems to refuse email
>>> from non-members.
>>>   
>>>       
>> I changed the option in mailman, that should be fixed.
>>     
>
> I thought lxc-devel was long past dead.
>   
I resurrected it for lxc userspace tool.

Re: [PATCH] Add powerpc signalfd syscall numbers

[Eric W. Biederman]

Daniel Lezcano <daniel.lezcano-GANU6spQydw@public.gmane.org> writes:

> I resurrected it for lxc userspace tool.

Makes sense.  I had not seen that before.

On that note I need to expect I need to sync up on user space tools
so that we can have one default tool that works for everyone.

Eric

Re: [PATCH] Add powerpc signalfd syscall numbers

[Daniel Lezcano]

Eric W. Biederman wrote:
> Daniel Lezcano <daniel.lezcano-GANU6spQydw@public.gmane.org> writes:
>
>   
>> I resurrected it for lxc userspace tool.
>>     
>
> Makes sense.  I had not seen that before.
>
> On that note I need to expect I need to sync up on user space tools
> so that we can have one default tool that works for everyone.
>   
Yes, that makes sense.
At present there are several people using it and proposing improvements 
or fixes on this mailing list.
The lxc tools will be in the opensuse 11.2 distro and is in the debian 
wishlist.

The main goal of the tool is to have a suiss army knif, most of the 
options are configurable.
The tools allow to do a simple unshare as well as booting a debian minimal.

The philosophy is to have something tunable acting at a low level and 
let the user to script the configuration of the container.

An overview:
http://lxc.sourceforge.net/lxc.html

The code is browsable here:
http://lxc.git.sourceforge.net/

The git is accessible here:
|git-clone git://lxc.git.sourceforge.net/gitroot/lxc|

Regards.
  -- Daniel

Re: [PATCH] Add powerpc signalfd syscall numbers

[Daniel Lezcano]

Matt Helsley wrote:
> Add signalfd and signalfd4 syscall number definitions for powerpc so
> that we may compile even with older platform headers.
> 
> Signed-off-by: Matt Helsley <matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> 
> diff --git a/src/lxc/start.c b/src/lxc/start.c
> index 476d695..051e70c 100644
> --- a/src/lxc/start.c

Applied. Thanks.