Re: [Patch] Move multiboot helpers out of the kernel

[phcoder <phcoder@gmail.com>]

Robert Millan wrote:
> On Sat, Mar 14, 2009 at 06:52:55PM +0100, phcoder wrote:
>> Robert Millan wrote:
>>> On Sat, Mar 14, 2009 at 12:35:09AM +0100, phcoder wrote:
>>>> Index: conf/i386-ieee1275.rmk
>>>> ===================================================================
>>>> --- conf/i386-ieee1275.rmk	(revision 2030)
>>>> +++ conf/i386-ieee1275.rmk	(working copy)
>>>> @@ -126,10 +126,12 @@
>>>>   # For _multiboot.mod.
>>>>  _multiboot_mod_SOURCES = loader/ieee1275/multiboot2.c \
>>>> +			 loader/i386/multiboot_helper.S \
>>> multiboot_helper.S is not being used on i386-ieee1275 AFAICT
>> How can it be if multiboot.c is the same for pc and ieee1275?
> 
> $ grep multiboot.c conf/*.rmk
> conf/i386-coreboot.rmk:_multiboot_mod_SOURCES = loader/i386/multiboot.c \
> conf/i386-pc.rmk:_multiboot_mod_SOURCES = loader/i386/multiboot.c \
> 
void
grub_mb2_arch_boot (grub_addr_t entry_addr, void *tags)
{
#if defined(__powerpc__)
   kernel_entry_t entry = (kernel_entry_t) entry_addr;
   entry (MULTIBOOT2_BOOTLOADER_MAGIC, tags, grub_ieee1275_entry_fn, 0, 0);
#elif defined(__i386__)
   grub_multiboot2_real_boot (entry_addr, tags);
#else
#error
#endif
}

As you see it uses grub_multiboot2_real_boot
>>> grub_dl_unload_all() just disappeared.  Is this intentional?  I
>>> tend to agree that grub_dl_unload_all() is a waste of time, but
>>> this should be discussed separately.
>> It is intentional because multiboot_real_boot is now in a module so we  
>> can't unload it
> 
> Ok then, I'm fine with disabling the unload.  What does everybody else
> think?
> 


-- 

Regards
Vladimir 'phcoder' Serbinenko