* [PATCH 12/24] [xen-unstable.hg] xenstored support for in-memory rather than FS based trivial DB (needed to run on mini-OS)
@ 2009-03-23 15:21 Alex Zeffertt
0 siblings, 0 replies; only message in thread
From: Alex Zeffertt @ 2009-03-23 15:21 UTC (permalink / raw)
To: xen-devel@lists.xensource.com
[-- Attachment #1: Type: text/plain, Size: 2 bytes --]
[-- Attachment #2: tdb_copy --]
[-- Type: text/plain, Size: 1361 bytes --]
tdb_copy (a xen modification to tdb?) should honor the TDB_INTERNAL flag
for in-memory databases.
TODO: leaks memory on error case
Signed-off-by: Diego Ongaro <diego.ongaro@citrix.com>
Signed-off-by: Alex Zeffertt <alex.zeffertt@eu.citrix.com>
---
diff -r 6bf15d571dcd tools/xenstore/tdb.c
--- a/tools/xenstore/tdb.c Fri Aug 01 16:50:39 2008 +0100
+++ b/tools/xenstore/tdb.c Fri Aug 01 16:50:40 2008 +0100
@@ -2103,6 +2103,42 @@
int fd, saved_errno;
TDB_CONTEXT *copy;
+ if (tdb->flags & TDB_INTERNAL) {
+ struct tdb_header *copydb;
+
+ copy = talloc_zero(outfile, TDB_CONTEXT);
+ if (copy == NULL) {
+ errno = ENOMEM;
+ goto intfail;
+ }
+ memcpy(copy, tdb, sizeof(TDB_CONTEXT));
+
+ if (copy->name || copy->locked || copy->device || copy->inode) {
+ fprintf(stderr, "tdb_copy assumption(s) failed\n");
+ goto intfail;
+ }
+
+ copydb = talloc_zero_size(copy, copy->map_size);
+ if (copydb == NULL) {
+ errno = ENOMEM;
+ goto intfail;
+ }
+ memcpy(copydb, copy->map_ptr, copy->map_size);
+ copy->map_ptr = (char*) copydb;
+
+ if (tdb_brlock(tdb, GLOBAL_LOCK, F_UNLCK, F_SETLKW, 0) == -1)
+ goto intfail;
+
+ copy->next = tdbs;
+ tdbs = copy;
+
+
+ return copy;
+intfail:
+ /* TODO (leaking memory is easier) */
+ return NULL;
+ }
+
fd = open(outfile, O_TRUNC|O_CREAT|O_WRONLY, 0640);
if (fd < 0)
return NULL;
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-03-23 15:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-23 15:21 [PATCH 12/24] [xen-unstable.hg] xenstored support for in-memory rather than FS based trivial DB (needed to run on mini-OS) Alex Zeffertt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.