Re: [Qemu-devel] [PATCH 2/2 -v2] gdbstub: Rework configuration via command line and monitor

[Jan Kiszka <jan.kiszka@web.de>]

[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]

Paul Brook wrote:
> On Saturday 21 March 2009, Jan Kiszka wrote:
>> Introduce a more powerful gdbstub configuration (system emulation olny)
>> via new switch '-gdb dev'. Keep '-s' as shorthand for '-gdb tcp::1234'.
>> Use the same syntax also for the corresponding monitor command
>> 'gdbserver'. Its default also remains to listen on port 1234.
> 
> I don't see how this is an improvement. In fact it provides less functionality 
> than the current -p, which is also consistent with other similar qemu 
> options.

Hmm, I was not able to find any further examples for this mixture of
standard device syntax and special interpretation of numerical values -
even in the qemu-doc, the only place where the special case of 'port'
was mentioned.

So I still see this as a significant improvements as it
 - aligns -gdb to the standard syntax use in -monitor, -serial or
   -parallel, making the interface more intuitive
 - documents this properly

I will adjust description to clarify that this patch refactors the
existing feature into a canonical form, but does not actually add a new one.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]