From: Christian Franke <Christian.Franke@t-online.de>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: precision formatting in grub_printf
Date: Tue, 24 Mar 2009 21:39:06 +0100 [thread overview]
Message-ID: <49C944EA.202@t-online.de> (raw)
In-Reply-To: <affa79920903161138o580c3216h617cf2666f4df7b7@mail.gmail.com>
Deepak Vankadaru wrote:
> Hi,
>
> There was a redundant piece of code in the diff file I sent earlier. I
> have removed it and prepared another patch file. I am attaching the
> same. Please use this one instead.
>
> Following is the changelog.
>
> Changelog:
> 2008-08-17 Deepak Vankadaru <deepak.vankadaru@gmail.com
> <mailto:deepak.vankadaru@gmail.com>>
>
> Support for precision formatting in grub_printf
>
> * kern/misc.c: modified grub_vsprintf to parse and handle
> precision formatting
>
Thanks.
Unfortunately, the patch can no longer be applied to current svn without
a conflict.
The precision parsing and '%s' precision (truncation) handling is
already implemented.
But the '%d' precision (zero fill) handling part of your patch is still
missing in the code.
Could you please repost an updated patch in diff -u format?
Note that the current code does not use a format2_default flag buts sets
format2 to ~0U ('infinite' :-) if no precision is specified.
Thanks
--
Christian Franke
prev parent reply other threads:[~2009-03-24 20:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-17 17:58 precision formatting in grub_printf Deepak Vankadaru
2008-08-17 21:14 ` Robert Millan
2008-08-18 5:22 ` Deepak Vankadaru
2008-08-22 12:26 ` Deepak Vankadaru
2009-03-12 8:49 ` Deepak Vankadaru
2009-03-13 19:20 ` Robert Millan
2009-03-16 18:38 ` Deepak Vankadaru
2009-03-18 10:09 ` Robert Millan
2009-03-18 10:49 ` Christian Franke
2009-03-24 20:39 ` Christian Franke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49C944EA.202@t-online.de \
--to=christian.franke@t-online.de \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.