From: Li Zefan <lizf@cn.fujitsu.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@elte.hu>, Jens Axboe <jens.axboe@oracle.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/5] blktrace: print human-readable act_mask
Date: Wed, 25 Mar 2009 10:55:08 +0800 [thread overview]
Message-ID: <49C99D0C.9070905@cn.fujitsu.com> (raw)
In-Reply-To: <alpine.DEB.2.00.0903241205320.22830@gandalf.stny.rr.com>
>> I'm really confused now. The prototype for blk_trace_str2mask has
>> two parameters. It is used with two parameters above, but then it is used
>> here with only one parameter. The blk_str2act_mask may have one, and that
>> is what is replaced.
>>
>> What am I missing?
>
> I'm dyslexic :-p
>
> I see now...
>
> The proto-type is blk_trace_mask2str
>
> but this is blk_trace_str2mask
>
> Nevermind,
>
Never mind, your review is always appreciated. :)
next prev parent reply other threads:[~2009-03-25 2:54 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-24 8:04 [PATCH 0/5] blktrace: various cleanups and fixes, part 2 Li Zefan
2009-03-24 8:04 ` [PATCH 1/5] blktrace: mark ddir_act and what2act const Li Zefan
2009-03-24 12:12 ` [tip:tracing/blktrace] blktrace: mark ddir_act[] const Li Zefan
2009-03-24 12:49 ` [PATCH 1/5] blktrace: mark ddir_act and what2act const Arnaldo Carvalho de Melo
2009-03-24 8:05 ` [PATCH 2/5] blktrace: fix wrong calculation of RWBS Li Zefan
2009-03-24 12:12 ` [tip:tracing/blktrace] " Li Zefan
2009-03-24 8:05 ` [PATCH 3/5] blktrace: fix off-by-one bug Li Zefan
2009-03-24 8:27 ` Ingo Molnar
2009-03-24 8:33 ` Li Zefan
2009-03-24 8:41 ` Li Zefan
2009-03-24 8:47 ` Ingo Molnar
2009-03-24 8:50 ` Li Zefan
2009-03-25 1:21 ` Li Zefan
2009-03-25 13:15 ` [tip:tracing/blktrace] " Li Zefan
2009-03-24 8:05 ` [PATCH 4/5] blktrace: fix t_error() Li Zefan
2009-03-24 8:44 ` Ingo Molnar
2009-03-24 12:12 ` [tip:tracing/blktrace] " Li Zefan
2009-03-24 12:51 ` [PATCH 4/5] " Arnaldo Carvalho de Melo
2009-03-24 8:06 ` [PATCH 5/5] blktrace: print human-readable act_mask Li Zefan
2009-03-24 8:39 ` Ingo Molnar
2009-03-24 9:01 ` Li Zefan
2009-03-24 8:39 ` Ingo Molnar
2009-03-24 8:46 ` Li Zefan
2009-03-24 9:43 ` Li Zefan
2009-03-24 9:48 ` Ingo Molnar
2009-03-24 12:12 ` [tip:tracing/blktrace] " Li Zefan
2009-03-24 15:48 ` [PATCH 5/5] " Steven Rostedt
2009-03-24 15:49 ` Steven Rostedt
2009-03-24 15:56 ` Ingo Molnar
2009-03-24 16:04 ` Steven Rostedt
2009-03-24 16:06 ` Steven Rostedt
2009-03-25 2:55 ` Li Zefan [this message]
2009-03-24 11:49 ` [PATCH 0/5] blktrace: various cleanups and fixes, part 2 Jens Axboe
2009-03-24 12:10 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49C99D0C.9070905@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.