From: Li Zefan <lizf@cn.fujitsu.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, acme@redhat.com, hpa@zytor.com,
mingo@redhat.com, lizf@cn.fujitsu.com, jens.axboe@oracle.com,
fweisbec@gmail.com, rostedt@goodmis.org, tglx@linutronix.de,
mingo@elte.hu
Subject: [tip:tracing/blktrace] blktrace: mark ddir_act[] const
Date: Tue, 24 Mar 2009 12:12:28 GMT [thread overview]
Message-ID: <tip-e4955c9986a27bb47ddeb6cd55803053f547e2e9@git.kernel.org> (raw)
In-Reply-To: <49C89415.5080503@cn.fujitsu.com>
Commit-ID: e4955c9986a27bb47ddeb6cd55803053f547e2e9
Gitweb: http://git.kernel.org/tip/e4955c9986a27bb47ddeb6cd55803053f547e2e9
Author: Li Zefan <lizf@cn.fujitsu.com>
AuthorDate: Tue, 24 Mar 2009 16:04:37 +0800
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 24 Mar 2009 13:08:59 +0100
blktrace: mark ddir_act[] const
Impact: cleanup
ddir_act and what2act always stay immutable.
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Acked-by: Jens Axboe <jens.axboe@oracle.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
LKML-Reference: <49C89415.5080503@cn.fujitsu.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
kernel/trace/blktrace.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
index 108f4f7..1ffcbd4 100644
--- a/kernel/trace/blktrace.c
+++ b/kernel/trace/blktrace.c
@@ -147,8 +147,8 @@ static int act_log_check(struct blk_trace *bt, u32 what, sector_t sector,
/*
* Data direction bit lookup
*/
-static u32 ddir_act[2] __read_mostly = { BLK_TC_ACT(BLK_TC_READ),
- BLK_TC_ACT(BLK_TC_WRITE) };
+static const u32 ddir_act[2] = { BLK_TC_ACT(BLK_TC_READ),
+ BLK_TC_ACT(BLK_TC_WRITE) };
/* The ilog2() calls fall out because they're constant */
#define MASK_TC_BIT(rw, __name) ((rw & (1 << BIO_RW_ ## __name)) << \
@@ -1116,10 +1116,10 @@ static void blk_tracer_reset(struct trace_array *tr)
blk_tracer_stop(tr);
}
-static struct {
+static const struct {
const char *act[2];
int (*print)(struct trace_seq *s, const struct trace_entry *ent);
-} what2act[] __read_mostly = {
+} what2act[] = {
[__BLK_TA_QUEUE] = {{ "Q", "queue" }, blk_log_generic },
[__BLK_TA_BACKMERGE] = {{ "M", "backmerge" }, blk_log_generic },
[__BLK_TA_FRONTMERGE] = {{ "F", "frontmerge" }, blk_log_generic },
next prev parent reply other threads:[~2009-03-24 12:13 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-24 8:04 [PATCH 0/5] blktrace: various cleanups and fixes, part 2 Li Zefan
2009-03-24 8:04 ` [PATCH 1/5] blktrace: mark ddir_act and what2act const Li Zefan
2009-03-24 12:12 ` Li Zefan [this message]
2009-03-24 12:49 ` Arnaldo Carvalho de Melo
2009-03-24 8:05 ` [PATCH 2/5] blktrace: fix wrong calculation of RWBS Li Zefan
2009-03-24 12:12 ` [tip:tracing/blktrace] " Li Zefan
2009-03-24 8:05 ` [PATCH 3/5] blktrace: fix off-by-one bug Li Zefan
2009-03-24 8:27 ` Ingo Molnar
2009-03-24 8:33 ` Li Zefan
2009-03-24 8:41 ` Li Zefan
2009-03-24 8:47 ` Ingo Molnar
2009-03-24 8:50 ` Li Zefan
2009-03-25 1:21 ` Li Zefan
2009-03-25 13:15 ` [tip:tracing/blktrace] " Li Zefan
2009-03-24 8:05 ` [PATCH 4/5] blktrace: fix t_error() Li Zefan
2009-03-24 8:44 ` Ingo Molnar
2009-03-24 12:12 ` [tip:tracing/blktrace] " Li Zefan
2009-03-24 12:51 ` [PATCH 4/5] " Arnaldo Carvalho de Melo
2009-03-24 8:06 ` [PATCH 5/5] blktrace: print human-readable act_mask Li Zefan
2009-03-24 8:39 ` Ingo Molnar
2009-03-24 9:01 ` Li Zefan
2009-03-24 8:39 ` Ingo Molnar
2009-03-24 8:46 ` Li Zefan
2009-03-24 9:43 ` Li Zefan
2009-03-24 9:48 ` Ingo Molnar
2009-03-24 12:12 ` [tip:tracing/blktrace] " Li Zefan
2009-03-24 15:48 ` [PATCH 5/5] " Steven Rostedt
2009-03-24 15:49 ` Steven Rostedt
2009-03-24 15:56 ` Ingo Molnar
2009-03-24 16:04 ` Steven Rostedt
2009-03-24 16:06 ` Steven Rostedt
2009-03-25 2:55 ` Li Zefan
2009-03-24 11:49 ` [PATCH 0/5] blktrace: various cleanups and fixes, part 2 Jens Axboe
2009-03-24 12:10 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-e4955c9986a27bb47ddeb6cd55803053f547e2e9@git.kernel.org \
--to=lizf@cn.fujitsu.com \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.