All of lore.kernel.org
 help / color / mirror / Atom feed
From: Milan Broz <mbroz@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] lvconvert --repair
Date: Wed, 25 Mar 2009 15:30:30 +0100	[thread overview]
Message-ID: <49CA4006.2010804@redhat.com> (raw)
In-Reply-To: <87skmkc7q5.fsf@eriador.mornfall.net>

Petr Rockai wrote:

> The manpage update is still missing, but all the rest should be addressed in
> the attached patch. (I will chop it up for commit, just sending in all the bits
> together). I'll trow the manpage together later (this should not interfere with
> review or acceptance, I hope).
please try this test - it tries to allocate new log - not sure if it is what we want,
but lvconvert fails but log lv is later visible, vg is still inconsistent
and I am confused what the correct state should be:-)

Milan

diff --git a/test/t-lvconvert-repair.sh b/test/t-lvconvert-repair.sh
index 2b72495..98a5ede 100644
--- a/test/t-lvconvert-repair.sh
+++ b/test/t-lvconvert-repair.sh
@@ -37,3 +37,10 @@ disable_dev $dev3
 lvconvert --repair $vg/mirror
 vgreduce --removemissing $vg
 
+enable_dev $dev3
+vgextend $vg $dev3
+lvcreate -m 2 -l 1 -n mirror2 $vg $dev1 $dev2 $dev3 $dev4
+vgchange -a n $vg
+pvremove -ff -y $dev4
+not echo 'y' | lvconvert --repair $vg/mirror2
+vgs




  reply	other threads:[~2009-03-25 14:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-30 10:10 [PATCH] lvconvert --repair Petr Rockai
2009-02-05 18:06 ` Milan Broz
2009-02-10 17:46   ` Petr Rockai
2009-02-12  9:41     ` Petr Rockai
2009-03-25 14:30       ` Milan Broz [this message]
2009-03-30 15:14         ` Petr Rockai
2009-04-22 17:43           ` Milan Broz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49CA4006.2010804@redhat.com \
    --to=mbroz@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.