From: Milan Broz <mbroz@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] lvconvert --repair
Date: Wed, 22 Apr 2009 19:43:25 +0200 [thread overview]
Message-ID: <49EF573D.2010407@redhat.com> (raw)
In-Reply-To: <8763hrf3fr.fsf@eriador.mornfall.net>
Petr Rockai wrote:
> Milan Broz <mbroz@redhat.com> writes:
>> please try this test - it tries to allocate new log - not sure if it is what we want,
>> but lvconvert fails but log lv is later visible, vg is still inconsistent
>> and I am confused what the correct state should be:-)
> The problem was that the code neglected to write out the consistent volume
> before trying to add new bits (which could obviously fail). The attached
> version of the patch fixes that (it also contains your test now).
Just minor things:
- some chunks (repairing vgreduce return code etc) are now already upstream
- there is also trivial merge problem, I am sure darcs merge code handle it:-)
- please check and remove some trailing whitespaces
- consider using vg->vgmem instead of cmd->mem - VG is locked
for the whole operation and failed PV list make sense only for that VG
- please add -i parameter to lvconvert in test script - it waits too long in tests
- add man page entry ;-)
Otherwise
Acked-by: Milan Broz <mbroz@redhat.com>
Milan
prev parent reply other threads:[~2009-04-22 17:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-30 10:10 [PATCH] lvconvert --repair Petr Rockai
2009-02-05 18:06 ` Milan Broz
2009-02-10 17:46 ` Petr Rockai
2009-02-12 9:41 ` Petr Rockai
2009-03-25 14:30 ` Milan Broz
2009-03-30 15:14 ` Petr Rockai
2009-04-22 17:43 ` Milan Broz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49EF573D.2010407@redhat.com \
--to=mbroz@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.