From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com
Subject: Re: [PATCH] xen/balloon: remove a warning.
Date: Fri, 27 Mar 2009 09:50:54 -0700 [thread overview]
Message-ID: <49CD03EE.2070003@goop.org> (raw)
In-Reply-To: <20090327061438.GL13054%yamahata@valinux.co.jp>
Isaku Yamahata wrote:
> This patch removes the following warning on ia64.
>
> drivers/xen/balloon.c: In function 'show_target':
> drivers/xen/balloon.c:516: warning: format '%llu' expects type 'long long unsigned int', but argument 3 has type 'long unsigned int'
>
Ah, the old long vs long long u64 bites again. OK.
J
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
> ---
> drivers/xen/balloon.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
> index efa4b36..b989ba6 100644
> --- a/drivers/xen/balloon.c
> +++ b/drivers/xen/balloon.c
> @@ -513,7 +513,8 @@ static ssize_t show_target(struct sys_device *dev, struct sysdev_attribute *attr
> char *buf)
> {
> return sprintf(buf, "%llu\n",
> - (u64)balloon_stats.target_pages << PAGE_SHIFT);
> + (unsigned long long)balloon_stats.target_pages <<
> + PAGE_SHIFT);
> }
>
> static ssize_t store_target(struct sys_device *dev,
>
WARNING: multiple messages have this Message-ID (diff)
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xen/balloon: remove a warning.
Date: Fri, 27 Mar 2009 09:50:54 -0700 [thread overview]
Message-ID: <49CD03EE.2070003@goop.org> (raw)
In-Reply-To: <20090327061438.GL13054%yamahata@valinux.co.jp>
Isaku Yamahata wrote:
> This patch removes the following warning on ia64.
>
> drivers/xen/balloon.c: In function 'show_target':
> drivers/xen/balloon.c:516: warning: format '%llu' expects type 'long long unsigned int', but argument 3 has type 'long unsigned int'
>
Ah, the old long vs long long u64 bites again. OK.
J
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
> ---
> drivers/xen/balloon.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
> index efa4b36..b989ba6 100644
> --- a/drivers/xen/balloon.c
> +++ b/drivers/xen/balloon.c
> @@ -513,7 +513,8 @@ static ssize_t show_target(struct sys_device *dev, struct sysdev_attribute *attr
> char *buf)
> {
> return sprintf(buf, "%llu\n",
> - (u64)balloon_stats.target_pages << PAGE_SHIFT);
> + (unsigned long long)balloon_stats.target_pages <<
> + PAGE_SHIFT);
> }
>
> static ssize_t store_target(struct sys_device *dev,
>
next prev parent reply other threads:[~2009-03-27 16:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-27 6:14 [PATCH] xen/balloon: remove a warning Isaku Yamahata
2009-03-27 6:14 ` Isaku Yamahata
2009-03-27 16:50 ` Jeremy Fitzhardinge [this message]
2009-03-27 16:50 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49CD03EE.2070003@goop.org \
--to=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.