All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Vesa Jääskeläinen" <chaac@nic.fi>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Split of the normal mode
Date: Sun, 29 Mar 2009 12:40:16 +0300	[thread overview]
Message-ID: <49CF4200.7010500@nic.fi> (raw)
In-Reply-To: <ca0f59980903290225u784b2421u5a50a9822ae27c7d@mail.gmail.com>

Bean wrote:
> Hi,
> 
> This patch split the function of normal mode into small modules, here
> is a summary:
> 
> 1, Move dynamic command loader to commands/dyncmd.c (dyncmd.mod)
> 2, Move automatic fs loader to fs/autofs.c (autofs.mod)
> 3, Split normal mode into three major parts:
> parser/normal - normal mode parser (nparser.mod)
> reader/normal - normal mode command line reader (nreader.mod)
> menu/text - menu viewer (tmenu.mod)
> 4, Generic menu function move to menu/menu.c and menu/menu_viewer.c. (menu.mod)
> 5, Misc function move to lib/misc.c lib/completion.c (misc.mod)
> 6, setjmp function move to lib/i386, lib/x86_64, lib/powerpc and
> lib/sparc64 (setjmp.mod)

Umh... I could somewhat agree with moving text menu out of normal.mod.
But...

I feel we have passed the over engineering milestone sometime ago... and
 I am not frankly happy about that...

Changes like this just make it a) harder to maintain, b) bigger overall
size impact, c) as a plus more modular approach...

I also fear that we seem to be missing some lead for the project that
could use his authority to make decisions...




  reply	other threads:[~2009-03-29  9:40 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-29  9:25 [PATCH] Split of the normal mode Bean
2009-03-29  9:40 ` Vesa Jääskeläinen [this message]
2009-03-29 10:09   ` Yoshinori K. Okuji
2009-03-29 10:43     ` phcoder
2009-03-29 10:53       ` Vesa Jääskeläinen
2009-03-29 11:33         ` phcoder
2009-03-29 11:51           ` Yoshinori K. Okuji
2009-03-29 12:09             ` Bean
2009-03-29 13:10               ` Yoshinori K. Okuji
2009-03-29 13:59                 ` Bean
2009-03-29 14:20                   ` Yoshinori K. Okuji
2009-03-29 14:30                     ` Bean
2009-03-29 14:54                       ` Yoshinori K. Okuji
2009-03-29 15:17                         ` Bean
2009-03-30 15:42                           ` Yoshinori K. Okuji
2009-03-30 20:04                 ` Colin D Bennett
2009-03-31  6:11                   ` Bean
2009-03-31 15:02                     ` Colin D Bennett
2009-03-29 13:00             ` phcoder
2009-03-29 14:51               ` Yoshinori K. Okuji
2009-03-29 17:07                 ` phcoder
2009-03-29 20:35                   ` phcoder
2009-03-30 15:49                     ` Yoshinori K. Okuji
2009-03-30 15:59                       ` phcoder
2009-04-01  7:43                         ` phcoder
2009-04-01  8:07                           ` David Miller
2009-04-01  9:22                             ` phcoder
2009-04-01 14:10                               ` Yoshinori K. Okuji
2009-04-01 16:14                                 ` phcoder
2009-03-29 11:29       ` Yoshinori K. Okuji
2009-03-29 11:40         ` David Miller
2009-03-29 12:55           ` Yoshinori K. Okuji
2009-03-29 13:23             ` Vesa Jääskeläinen
2009-03-29 14:49               ` Yoshinori K. Okuji
2009-03-29 15:43                 ` Vesa Jääskeläinen
2009-03-29 20:26               ` David Miller
2009-03-29 20:24             ` David Miller
2009-03-29 20:38               ` phcoder
2009-03-30 15:43                 ` Bean
2009-03-30 16:22                   ` Yoshinori K. Okuji
2009-03-30 16:38                     ` Bean
2009-03-30 16:35                   ` Vesa Jääskeläinen
2009-03-29 11:59         ` General design (was Re: [PATCH] Split of the normal mode) phcoder
2009-03-29 10:48     ` [PATCH] Split of the normal mode Vesa Jääskeläinen
2009-03-29 11:39       ` Yoshinori K. Okuji
2009-03-29 12:17       ` Vesa Jääskeläinen
2009-04-01 13:19     ` Robert Millan
2009-04-01 14:15       ` Yoshinori K. Okuji

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49CF4200.7010500@nic.fi \
    --to=chaac@nic.fi \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.