From: phcoder <phcoder@gmail.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: Move loader.c out of the kernel
Date: Tue, 31 Mar 2009 10:56:24 +0200 [thread overview]
Message-ID: <49D1DAB8.90703@gmail.com> (raw)
In-Reply-To: <49C63395.9090304@gmail.com>
With a new swing in normal.mod splitting I think we should reconsider
this patch. It's useless to keep loader.c in kernel without boot
command. IMO it should be moved either to a perate boot.mod (my
preference) or to minicmd.mod (not a good option IMO)
phcoder wrote:
> Hello. Now when boot command isn't in kernel anymore I don't see why
> loader.c stays in kernel. Here is the patch to move it to boot.mod
> 2009-03-22 Vladimir Serbinenko <phcoder@gmail.com>
>
> Move loader out of the kernel
>
> * kern/loader.c: moved to ...
> * commands/boot.c: ... moved here
> * commands/minicmd.c (grub_mini_cmd_boot): moved to ...
> * commands/boot.c (grub_cmd_boot): moved here. All users updated
> * include/grub/kernel.h (grub_machine_fini): export
> * include/grub/loader.h (grub_loader_is_loaded): update declaration
> (grub_loader_set): likewise
> (grub_loader_unset): likewise
> (grub_loader_boot): likewise
> * conf/common.rmk: new module boot.mod
> (pkglib_MODULES): add boot.mod
> * conf/i386-coreboot.rmk (kernel_elf_SOURCES): remove kern/loader.c
> (grub_emu_SOURCES): likewise
> * conf/i386-efi.rmk (kernel_elf_SOURCES): likewise
> (grub_emu_SOURCES): likewise
> * conf/i386-ieee1275.rmk (kernel_elf_SOURCES): likewise
> (grub_emu_SOURCES): likewise
> * conf/i386-pc.rmk (kernel_elf_SOURCES): likewise
> (grub_emu_SOURCES): likewise
> * conf/powerpc-ieee1275.rmk (kernel_elf_SOURCES): likewise
> (grub_emu_SOURCES): likewise
> * conf/sparcs64-ieee1275.rmk (kernel_elf_SOURCES): likewise
> (grub_emu_SOURCES): likewise
> * conf/x86_64-efi.rmk (kernel_elf_SOURCES): likewise
> (grub_emu_SOURCES): likewise
>
>
--
Regards
Vladimir 'phcoder' Serbinenko
next prev parent reply other threads:[~2009-03-31 8:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-22 12:48 Move loader.c out of the kernel phcoder
2009-03-22 12:57 ` Yoshinori K. Okuji
2009-03-22 13:06 ` phcoder
2009-03-22 13:12 ` Yoshinori K. Okuji
2009-03-22 13:30 ` phcoder
2009-03-22 14:01 ` Yoshinori K. Okuji
2009-03-22 14:19 ` phcoder
2009-03-22 14:59 ` Yoshinori K. Okuji
2009-03-22 14:54 ` Robert Millan
2009-03-31 8:56 ` phcoder [this message]
2009-04-01 13:52 ` Yoshinori K. Okuji
2009-04-01 14:19 ` Robert Millan
2009-04-01 14:42 ` Yoshinori K. Okuji
2009-04-01 15:12 ` phcoder
2009-04-01 15:21 ` Vesa Jääskeläinen
2009-04-01 15:46 ` phcoder
2009-04-05 15:19 ` phcoder
2009-04-15 12:46 ` phcoder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D1DAB8.90703@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.