* [U-Boot] [PATCH] mpc83xx: Set guarded bit on BAT that covers the end of the address space
@ 2009-03-30 22:56 Kim Phillips
2009-03-31 20:51 ` Wolfgang Denk
0 siblings, 1 reply; 6+ messages in thread
From: Kim Phillips @ 2009-03-30 22:56 UTC (permalink / raw)
To: u-boot
continuation of commit a5d7049a4 to remaining mpc83xx boards that suffer
from the same problem.
Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
CC: Scott Wood <scottwood@freescale.com>
---
include/configs/MPC8349EMDS.h | 3 ++-
include/configs/MPC8349ITX.h | 3 ++-
include/configs/MVBLM7.h | 3 ++-
include/configs/SIMPC8313.h | 2 +-
include/configs/sbc8349.h | 3 ++-
5 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/include/configs/MPC8349EMDS.h b/include/configs/MPC8349EMDS.h
index b3c0e2d..0d1d663 100644
--- a/include/configs/MPC8349EMDS.h
+++ b/include/configs/MPC8349EMDS.h
@@ -683,7 +683,8 @@
#define CONFIG_SYS_IBAT5U (CONFIG_SYS_IMMR | BATU_BL_256M | BATU_VS | BATU_VP)
/* SDRAM @ 0xF0000000, stack in DCACHE 0xFDF00000 & FLASH @ 0xFE000000 */
-#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_MEMCOHERENCE)
+#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_MEMCOHERENCE | \
+ BATL_GUARDEDSTORAGE)
#define CONFIG_SYS_IBAT6U (0xF0000000 | BATU_BL_256M | BATU_VS | BATU_VP)
#define CONFIG_SYS_IBAT7L (0)
diff --git a/include/configs/MPC8349ITX.h b/include/configs/MPC8349ITX.h
index 38a7386..ab6fe55 100644
--- a/include/configs/MPC8349ITX.h
+++ b/include/configs/MPC8349ITX.h
@@ -615,7 +615,8 @@ boards, we say we have two, but don't display a message if we find only one. */
#define CONFIG_SYS_IBAT5U (CONFIG_SYS_IMMR | BATU_BL_256M | BATU_VS | BATU_VP)
/* SDRAM @ 0xF0000000, stack in DCACHE 0xFDF00000 & FLASH @ 0xFE000000 */
-#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_MEMCOHERENCE)
+#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_MEMCOHERENCE | \
+ BATL_GUARDEDSTORAGE)
#define CONFIG_SYS_IBAT6U (0xF0000000 | BATU_BL_256M | BATU_VS | BATU_VP)
#define CONFIG_SYS_IBAT7L 0
diff --git a/include/configs/MVBLM7.h b/include/configs/MVBLM7.h
index 4ecf806..b321825 100644
--- a/include/configs/MVBLM7.h
+++ b/include/configs/MVBLM7.h
@@ -360,7 +360,8 @@
#define CONFIG_SYS_IBAT5U (CONFIG_SYS_IMMR | BATU_BL_256M | BATU_VS | BATU_VP)
/* stack in DCACHE 0xFDF00000 & FLASH @ 0xFF800000 */
-#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_MEMCOHERENCE)
+#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_MEMCOHERENCE | \
+ BATL_GUARDEDSTORAGE)
#define CONFIG_SYS_IBAT6U (0xF0000000 | BATU_BL_256M | BATU_VS | BATU_VP)
#define CONFIG_SYS_IBAT7L 0
#define CONFIG_SYS_IBAT7U 0
diff --git a/include/configs/SIMPC8313.h b/include/configs/SIMPC8313.h
index e20527e..79582e1 100644
--- a/include/configs/SIMPC8313.h
+++ b/include/configs/SIMPC8313.h
@@ -437,7 +437,7 @@
#define CONFIG_SYS_IBAT5U (CONFIG_SYS_IMMR | BATU_BL_256M | BATU_VS | BATU_VP)
/* SDRAM @ 0xF0000000, stack in DCACHE 0xFDF00000 & FLASH @ 0xFE000000 */
-#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10)
+#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_GUARDEDSTORAGE)
#define CONFIG_SYS_IBAT6U (0xF0000000 | BATU_BL_256M | BATU_VS | BATU_VP)
#define CONFIG_SYS_IBAT7L (0)
diff --git a/include/configs/sbc8349.h b/include/configs/sbc8349.h
index f476e3e..42033ac 100644
--- a/include/configs/sbc8349.h
+++ b/include/configs/sbc8349.h
@@ -605,7 +605,8 @@
#define CONFIG_SYS_IBAT5U (CONFIG_SYS_IMMR | BATU_BL_256M | BATU_VS | BATU_VP)
/* SDRAM @ 0xF0000000, stack in DCACHE 0xFDF00000 & FLASH @ 0xFE000000 */
-#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_MEMCOHERENCE)
+#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_MEMCOHERENCE | \
+ BATL_GUARDEDSTORAGE)
#define CONFIG_SYS_IBAT6U (0xF0000000 | BATU_BL_256M | BATU_VS | BATU_VP)
#define CONFIG_SYS_IBAT7L (0)
--
1.6.1.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] mpc83xx: Set guarded bit on BAT that covers the end of the address space
2009-03-30 22:56 [U-Boot] [PATCH] mpc83xx: Set guarded bit on BAT that covers the end of the address space Kim Phillips
@ 2009-03-31 20:51 ` Wolfgang Denk
2009-03-31 21:04 ` Scott Wood
0 siblings, 1 reply; 6+ messages in thread
From: Wolfgang Denk @ 2009-03-31 20:51 UTC (permalink / raw)
To: u-boot
Dear Kim Phillips,
In message <20090330175628.602dae2f.kim.phillips@freescale.com> you wrote:
> continuation of commit a5d7049a4 to remaining mpc83xx boards that suffer
> from the same problem.
>
> Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
> CC: Scott Wood <scottwood@freescale.com>
Umm... what does that mean: "continuation of commit a5d7049a4"?
If these commits belong together logically, you must not split them
apart.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You can do this in a number of ways. IBM chose to do all of them.
Why do you find that funny? -- D. Taylor, Computer Science 350
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] mpc83xx: Set guarded bit on BAT that covers the end of the address space
2009-03-31 20:51 ` Wolfgang Denk
@ 2009-03-31 21:04 ` Scott Wood
2009-03-31 21:24 ` Wolfgang Denk
0 siblings, 1 reply; 6+ messages in thread
From: Scott Wood @ 2009-03-31 21:04 UTC (permalink / raw)
To: u-boot
Wolfgang Denk wrote:
> Dear Kim Phillips,
>
> In message <20090330175628.602dae2f.kim.phillips@freescale.com> you wrote:
>> continuation of commit a5d7049a4 to remaining mpc83xx boards that suffer
>> from the same problem.
>>
>> Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
>> CC: Scott Wood <scottwood@freescale.com>
>
> Umm... what does that mean: "continuation of commit a5d7049a4"?
>
> If these commits belong together logically, you must not split them
> apart.
There's no bisectability problem; it's just similar bugs being fixed on
other boards.
-Scott
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] mpc83xx: Set guarded bit on BAT that covers the end of the address space
2009-03-31 21:04 ` Scott Wood
@ 2009-03-31 21:24 ` Wolfgang Denk
2009-03-31 22:32 ` Kim Phillips
0 siblings, 1 reply; 6+ messages in thread
From: Wolfgang Denk @ 2009-03-31 21:24 UTC (permalink / raw)
To: u-boot
Dear Scott Wood,
In message <49D28575.1040303@freescale.com> you wrote:
>
> > Umm... what does that mean: "continuation of commit a5d7049a4"?
> >
> > If these commits belong together logically, you must not split them
> > apart.
>
> There's no bisectability problem; it's just similar bugs being fixed on
> other boards.
why not fix them in a single commit, then?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The most difficult thing in the world is to know how to do a thing
and to watch someone else doing it wrong, without commenting.
-- T.H. White
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] mpc83xx: Set guarded bit on BAT that covers the end of the address space
2009-03-31 21:24 ` Wolfgang Denk
@ 2009-03-31 22:32 ` Kim Phillips
0 siblings, 0 replies; 6+ messages in thread
From: Kim Phillips @ 2009-03-31 22:32 UTC (permalink / raw)
To: u-boot
On Tue, 31 Mar 2009 23:24:42 +0200
Wolfgang Denk <wd@denx.de> wrote:
> Dear Scott Wood,
>
> In message <49D28575.1040303@freescale.com> you wrote:
> >
> > > Umm... what does that mean: "continuation of commit a5d7049a4"?
> > >
> > > If these commits belong together logically, you must not split them
> > > apart.
> >
> > There's no bisectability problem; it's just similar bugs being fixed on
> > other boards.
>
> why not fix them in a single commit, then?
this sounds reasonable - it gets rid of a moot commit, saving bisection
its traversal. I'll add this to Scott's original patch and explain what
I did between the s-o-b lines.
Kim
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] mpc83xx: Set guarded bit on BAT that covers the end of the address space
@ 2009-03-31 22:49 Kim Phillips
0 siblings, 0 replies; 6+ messages in thread
From: Kim Phillips @ 2009-03-31 22:49 UTC (permalink / raw)
To: u-boot
From: Scott Wood <scottwood@freescale.com>
The mpc8313erdb board currently sets DBAT6 to cover all of the final 256MiB of
address space; however, not all of this space is covered by a device. In
particular, flash sits at 0xfe000000-0xfe7fffff, and nothing is mapped
at the far end of the address space.
In zlib, there is a loop that references p[-1] if p is non-NULL. Under
some circumstances, this leads to the CPU speculatively loading from
0xfffffff8 if p is NULL. This leads to a machine check.
Signed-off-by: Scott Wood <scottwood@freescale.com>
continuation to the remaining mpc83xx boards that suffer from the same problem.
Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
---
include/configs/MPC8313ERDB.h | 2 +-
include/configs/MPC8349EMDS.h | 3 ++-
include/configs/MPC8349ITX.h | 3 ++-
include/configs/MVBLM7.h | 3 ++-
include/configs/SIMPC8313.h | 2 +-
include/configs/sbc8349.h | 3 ++-
6 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/include/configs/MPC8313ERDB.h b/include/configs/MPC8313ERDB.h
index 0ef4eba..21aedee 100644
--- a/include/configs/MPC8313ERDB.h
+++ b/include/configs/MPC8313ERDB.h
@@ -544,7 +544,7 @@
#define CONFIG_SYS_IBAT5U (CONFIG_SYS_IMMR | BATU_BL_256M | BATU_VS | BATU_VP)
/* SDRAM @ 0xF0000000, stack in DCACHE 0xFDF00000 & FLASH @ 0xFE000000 */
-#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10)
+#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_GUARDEDSTORAGE)
#define CONFIG_SYS_IBAT6U (0xF0000000 | BATU_BL_256M | BATU_VS | BATU_VP)
#define CONFIG_SYS_IBAT7L (0)
diff --git a/include/configs/MPC8349EMDS.h b/include/configs/MPC8349EMDS.h
index b3c0e2d..0d1d663 100644
--- a/include/configs/MPC8349EMDS.h
+++ b/include/configs/MPC8349EMDS.h
@@ -683,7 +683,8 @@
#define CONFIG_SYS_IBAT5U (CONFIG_SYS_IMMR | BATU_BL_256M | BATU_VS | BATU_VP)
/* SDRAM @ 0xF0000000, stack in DCACHE 0xFDF00000 & FLASH @ 0xFE000000 */
-#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_MEMCOHERENCE)
+#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_MEMCOHERENCE | \
+ BATL_GUARDEDSTORAGE)
#define CONFIG_SYS_IBAT6U (0xF0000000 | BATU_BL_256M | BATU_VS | BATU_VP)
#define CONFIG_SYS_IBAT7L (0)
diff --git a/include/configs/MPC8349ITX.h b/include/configs/MPC8349ITX.h
index 38a7386..ab6fe55 100644
--- a/include/configs/MPC8349ITX.h
+++ b/include/configs/MPC8349ITX.h
@@ -615,7 +615,8 @@ boards, we say we have two, but don't display a message if we find only one. */
#define CONFIG_SYS_IBAT5U (CONFIG_SYS_IMMR | BATU_BL_256M | BATU_VS | BATU_VP)
/* SDRAM @ 0xF0000000, stack in DCACHE 0xFDF00000 & FLASH @ 0xFE000000 */
-#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_MEMCOHERENCE)
+#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_MEMCOHERENCE | \
+ BATL_GUARDEDSTORAGE)
#define CONFIG_SYS_IBAT6U (0xF0000000 | BATU_BL_256M | BATU_VS | BATU_VP)
#define CONFIG_SYS_IBAT7L 0
diff --git a/include/configs/MVBLM7.h b/include/configs/MVBLM7.h
index 4ecf806..b321825 100644
--- a/include/configs/MVBLM7.h
+++ b/include/configs/MVBLM7.h
@@ -360,7 +360,8 @@
#define CONFIG_SYS_IBAT5U (CONFIG_SYS_IMMR | BATU_BL_256M | BATU_VS | BATU_VP)
/* stack in DCACHE 0xFDF00000 & FLASH @ 0xFF800000 */
-#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_MEMCOHERENCE)
+#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_MEMCOHERENCE | \
+ BATL_GUARDEDSTORAGE)
#define CONFIG_SYS_IBAT6U (0xF0000000 | BATU_BL_256M | BATU_VS | BATU_VP)
#define CONFIG_SYS_IBAT7L 0
#define CONFIG_SYS_IBAT7U 0
diff --git a/include/configs/SIMPC8313.h b/include/configs/SIMPC8313.h
index e20527e..79582e1 100644
--- a/include/configs/SIMPC8313.h
+++ b/include/configs/SIMPC8313.h
@@ -437,7 +437,7 @@
#define CONFIG_SYS_IBAT5U (CONFIG_SYS_IMMR | BATU_BL_256M | BATU_VS | BATU_VP)
/* SDRAM @ 0xF0000000, stack in DCACHE 0xFDF00000 & FLASH @ 0xFE000000 */
-#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10)
+#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_GUARDEDSTORAGE)
#define CONFIG_SYS_IBAT6U (0xF0000000 | BATU_BL_256M | BATU_VS | BATU_VP)
#define CONFIG_SYS_IBAT7L (0)
diff --git a/include/configs/sbc8349.h b/include/configs/sbc8349.h
index f476e3e..42033ac 100644
--- a/include/configs/sbc8349.h
+++ b/include/configs/sbc8349.h
@@ -605,7 +605,8 @@
#define CONFIG_SYS_IBAT5U (CONFIG_SYS_IMMR | BATU_BL_256M | BATU_VS | BATU_VP)
/* SDRAM @ 0xF0000000, stack in DCACHE 0xFDF00000 & FLASH @ 0xFE000000 */
-#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_MEMCOHERENCE)
+#define CONFIG_SYS_IBAT6L (0xF0000000 | BATL_PP_10 | BATL_MEMCOHERENCE | \
+ BATL_GUARDEDSTORAGE)
#define CONFIG_SYS_IBAT6U (0xF0000000 | BATU_BL_256M | BATU_VS | BATU_VP)
#define CONFIG_SYS_IBAT7L (0)
--
1.6.1.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-03-31 22:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-30 22:56 [U-Boot] [PATCH] mpc83xx: Set guarded bit on BAT that covers the end of the address space Kim Phillips
2009-03-31 20:51 ` Wolfgang Denk
2009-03-31 21:04 ` Scott Wood
2009-03-31 21:24 ` Wolfgang Denk
2009-03-31 22:32 ` Kim Phillips
-- strict thread matches above, loose matches on Subject: below --
2009-03-31 22:49 Kim Phillips
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.