From: Eric Dumazet <dada1@cosmosbay.com>
To: Ingo Molnar <mingo@elte.hu>, Tejun Heo <htejun@gmail.com>
Cc: linux kernel <linux-kernel@vger.kernel.org>,
Linux Netdev List <netdev@vger.kernel.org>,
Joe Perches <joe@perches.com>
Subject: [PATCH] x86: percpu_to_op() misses memory and flags clobbers
Date: Wed, 01 Apr 2009 10:13:06 +0200 [thread overview]
Message-ID: <49D32212.80607@cosmosbay.com> (raw)
While playing with new percpu_{read|write|add|sub} stuff in network tree,
I found x86 asm was a litle bit optimistic.
We need to tell gcc that percpu_{write|add|sub|or|xor} are modyfing
memory and possibly eflags. We could add another parameter to percpu_to_op()
to separate the plain "mov" case (not changing eflags),
but let keep it simple for the moment.
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
diff --git a/arch/x86/include/asm/percpu.h b/arch/x86/include/asm/percpu.h
index aee103b..fd4f8ec 100644
--- a/arch/x86/include/asm/percpu.h
+++ b/arch/x86/include/asm/percpu.h
@@ -82,22 +82,26 @@ do { \
case 1: \
asm(op "b %1,"__percpu_arg(0) \
: "+m" (var) \
- : "ri" ((T__)val)); \
+ : "ri" ((T__)val) \
+ : "memory", "cc"); \
break; \
case 2: \
asm(op "w %1,"__percpu_arg(0) \
: "+m" (var) \
- : "ri" ((T__)val)); \
+ : "ri" ((T__)val) \
+ : "memory", "cc"); \
break; \
case 4: \
asm(op "l %1,"__percpu_arg(0) \
: "+m" (var) \
- : "ri" ((T__)val)); \
+ : "ri" ((T__)val) \
+ : "memory", "cc"); \
break; \
case 8: \
asm(op "q %1,"__percpu_arg(0) \
: "+m" (var) \
- : "re" ((T__)val)); \
+ : "re" ((T__)val) \
+ : "memory", "cc"); \
break; \
default: __bad_percpu_size(); \
} \
next reply other threads:[~2009-04-01 8:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-01 8:13 Eric Dumazet [this message]
2009-04-01 9:02 ` [PATCH] x86: percpu_to_op() misses memory and flags clobbers Jeremy Fitzhardinge
2009-04-01 10:14 ` Eric Dumazet
2009-04-01 16:12 ` Ingo Molnar
2009-04-01 16:41 ` Jeremy Fitzhardinge
2009-04-01 16:44 ` Ingo Molnar
2009-04-01 17:13 ` Eric Dumazet
2009-04-01 18:07 ` Jeremy Fitzhardinge
2009-04-01 18:47 ` Eric Dumazet
2009-04-02 9:52 ` Herbert Xu
2009-04-02 14:12 ` Jeremy Fitzhardinge
2009-04-01 18:44 ` [RFC] percpu: convert SNMP mibs to new infra Eric Dumazet
2009-04-02 0:13 ` Tejun Heo
2009-04-02 4:05 ` Ingo Molnar
2009-04-02 8:07 ` [PATCH] " Eric Dumazet
2009-04-03 0:39 ` Tejun Heo
2009-04-03 17:10 ` Ingo Molnar
2009-04-02 5:04 ` [RFC] " Rusty Russell
2009-04-02 5:19 ` Eric Dumazet
2009-04-02 11:46 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D32212.80607@cosmosbay.com \
--to=dada1@cosmosbay.com \
--cc=htejun@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.