From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: xen-devel <xen-devel@lists.xensource.com>
Subject: [PATCH] fix process_portio_intercept
Date: Wed, 01 Apr 2009 15:19:44 +0100 [thread overview]
Message-ID: <49D37800.6000500@eu.citrix.com> (raw)
Hi all,
process_portio_intercept and hvm_mmio_access do not correctly check the
return value of the intercept action functions they are calling.
In particular they are setting p->count to i even if i is 0 and the
action function returned X86EMUL_UNHANDLEABLE, leading to errors.
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
---
diff -r dbc4014882d0 xen/arch/x86/hvm/intercept.c
--- a/xen/arch/x86/hvm/intercept.c Wed Apr 01 08:36:21 2009 +0100
+++ b/xen/arch/x86/hvm/intercept.c Wed Apr 01 15:15:29 2009 +0100
@@ -100,8 +100,10 @@
}
}
- if ( (p->count = i) != 0 )
+ if ( i > 0 ) {
+ p->count = i;
rc = X86EMUL_OKAY;
+ }
return rc;
}
@@ -165,8 +167,10 @@
}
}
- if ( (p->count = i) != 0 )
+ if ( i > 0 ) {
+ p->count = i;
rc = X86EMUL_OKAY;
+ }
return rc;
}
reply other threads:[~2009-04-01 14:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D37800.6000500@eu.citrix.com \
--to=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.