* [PATCH] fix process_portio_intercept
@ 2009-04-01 14:19 Stefano Stabellini
0 siblings, 0 replies; only message in thread
From: Stefano Stabellini @ 2009-04-01 14:19 UTC (permalink / raw)
To: xen-devel
Hi all,
process_portio_intercept and hvm_mmio_access do not correctly check the
return value of the intercept action functions they are calling.
In particular they are setting p->count to i even if i is 0 and the
action function returned X86EMUL_UNHANDLEABLE, leading to errors.
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
---
diff -r dbc4014882d0 xen/arch/x86/hvm/intercept.c
--- a/xen/arch/x86/hvm/intercept.c Wed Apr 01 08:36:21 2009 +0100
+++ b/xen/arch/x86/hvm/intercept.c Wed Apr 01 15:15:29 2009 +0100
@@ -100,8 +100,10 @@
}
}
- if ( (p->count = i) != 0 )
+ if ( i > 0 ) {
+ p->count = i;
rc = X86EMUL_OKAY;
+ }
return rc;
}
@@ -165,8 +167,10 @@
}
}
- if ( (p->count = i) != 0 )
+ if ( i > 0 ) {
+ p->count = i;
rc = X86EMUL_OKAY;
+ }
return rc;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-04-01 14:19 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-01 14:19 [PATCH] fix process_portio_intercept Stefano Stabellini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.