The errors appear when compiling kvm-guest-drivers on kernel-2.6.29

The errors appear when compiling kvm-guest-drivers on kernel-2.6.29

[Zhiyong Wu]

HI,

I have recently setup a guest network in KVM,

when i tried to compile kvm guest driver - virtio on kernel-2.6.29, an
issue has appeared

(1) the version of kvm guest driver

[root@fedora9 kvm-guest-drivers-linux {master}]$ git describe
kvm-guest-drivers-linux-1-13-gae1ae62

(2) the output of make

[root@fedora9 kvm-guest-drivers-linux {master}]$ make
make -C /lib/modules/2.6.29/build M=`pwd` "$@"
make[1]: Entering directory `/usr/src/linux-2.6.29'
  CC [M]  /home/zwu/study/virt/kvm-guest-drivers-linux/virtio_net.o
/home/zwu/study/virt/kvm-guest-drivers-linux/virtio_net.c: In function
\u2018xmit_skb\u2019:
/home/zwu/study/virt/kvm-guest-drivers-linux/virtio_net.c:544: error:
\u2018CHECKSUM_HW\u2019 undeclared (first use in this function)
/home/zwu/study/virt/kvm-guest-drivers-linux/virtio_net.c:544: error:
(Each undeclared identifier is reported only once
/home/zwu/study/virt/kvm-guest-drivers-linux/virtio_net.c:544: error:
for each function it appears in.)
/home/zwu/study/virt/kvm-guest-drivers-linux/virtio_net.c:550: error:
\u2018struct sk_buff\u2019 has no member named \u2018h\u2019
make[2]: *** [/home/zwu/study/virt/kvm-guest-drivers-linux/virtio_net.o] Error 1
make[1]: *** [_module_/home/zwu/study/virt/kvm-guest-drivers-linux] Error 2
make[1]: Leaving directory `/usr/src/linux-2.6.29'
make: *** [all] Error 2


Cheers,

Zhiyong Wu

Re: The errors appear when compiling kvm-guest-drivers on kernel-2.6.29

[Zhiyong Wu]

In virtio_net.c,

#ifdef COMPAT_csum_offset
        if (skb->ip_summed == CHECKSUM_HW) {
#else
        if (skb->ip_summed == CHECKSUM_PARTIAL) {

It seems that CHECKSUM_HW is not declared.

In skbuff.h, only the macros below are defined.

/* Don't change this without changing skb_csum_unnecessary! */
#define CHECKSUM_NONE 0
#define CHECKSUM_UNNECESSARY 1
#define CHECKSUM_COMPLETE 2
#define CHECKSUM_PARTIAL 3

Cheers,

Zhiyong Wu

On Thu, Apr 2, 2009 at 12:10 PM, Zhiyong Wu <zwu.kernel@gmail.com> wrote:
> HI,
>
> I have recently setup a guest network in KVM,
>
> when i tried to compile kvm guest driver - virtio on kernel-2.6.29, an
> issue has appeared
>
> (1) the version of kvm guest driver
>
> [root@fedora9 kvm-guest-drivers-linux {master}]$ git describe
> kvm-guest-drivers-linux-1-13-gae1ae62
>
> (2) the output of make
>
> [root@fedora9 kvm-guest-drivers-linux {master}]$ make
> make -C /lib/modules/2.6.29/build M=`pwd` "$@"
> make[1]: Entering directory `/usr/src/linux-2.6.29'
>  CC [M]  /home/zwu/study/virt/kvm-guest-drivers-linux/virtio_net.o
> /home/zwu/study/virt/kvm-guest-drivers-linux/virtio_net.c: In function
> \u2018xmit_skb\u2019:
> /home/zwu/study/virt/kvm-guest-drivers-linux/virtio_net.c:544: error:
> \u2018CHECKSUM_HW\u2019 undeclared (first use in this function)
> /home/zwu/study/virt/kvm-guest-drivers-linux/virtio_net.c:544: error:
> (Each undeclared identifier is reported only once
> /home/zwu/study/virt/kvm-guest-drivers-linux/virtio_net.c:544: error:
> for each function it appears in.)
> /home/zwu/study/virt/kvm-guest-drivers-linux/virtio_net.c:550: error:
> \u2018struct sk_buff\u2019 has no member named \u2018h\u2019
> make[2]: *** [/home/zwu/study/virt/kvm-guest-drivers-linux/virtio_net.o] Error 1
> make[1]: *** [_module_/home/zwu/study/virt/kvm-guest-drivers-linux] Error 2
> make[1]: Leaving directory `/usr/src/linux-2.6.29'
> make: *** [all] Error 2
>
>
> Cheers,
>
> Zhiyong Wu
>

Re: The errors appear when compiling kvm-guest-drivers on kernel-2.6.29

[Brian Jackson]

I don't think the kvm-guest-drivers are still well maintained (they haven't 
been touched in 5 months). If you are using kernel 2.6.29, it already has 
virtio drivers and you don't need the kvm-guest-drivers tree at all.

--Brian Jackson



On Wednesday 01 April 2009 23:10:43 Zhiyong Wu wrote:
> HI,
>
> I have recently setup a guest network in KVM,
>
> when i tried to compile kvm guest driver - virtio on kernel-2.6.29, an
> issue has appeared
>
> (1) the version of kvm guest driver
>
> [root@fedora9 kvm-guest-drivers-linux {master}]$ git describe
> kvm-guest-drivers-linux-1-13-gae1ae62
>
> (2) the output of make
>
> [root@fedora9 kvm-guest-drivers-linux {master}]$ make
> make -C /lib/modules/2.6.29/build M=`pwd` "$@"
> make[1]: Entering directory `/usr/src/linux-2.6.29'
>   CC [M]  /home/zwu/study/virt/kvm-guest-drivers-linux/virtio_net.o
> /home/zwu/study/virt/kvm-guest-drivers-linux/virtio_net.c: In function
> \u2018xmit_skb\u2019:
> /home/zwu/study/virt/kvm-guest-drivers-linux/virtio_net.c:544: error:
> \u2018CHECKSUM_HW\u2019 undeclared (first use in this function)
> /home/zwu/study/virt/kvm-guest-drivers-linux/virtio_net.c:544: error:
> (Each undeclared identifier is reported only once
> /home/zwu/study/virt/kvm-guest-drivers-linux/virtio_net.c:544: error:
> for each function it appears in.)
> /home/zwu/study/virt/kvm-guest-drivers-linux/virtio_net.c:550: error:
> \u2018struct sk_buff\u2019 has no member named \u2018h\u2019
> make[2]: *** [/home/zwu/study/virt/kvm-guest-drivers-linux/virtio_net.o]
> Error 1 make[1]: *** [_module_/home/zwu/study/virt/kvm-guest-drivers-linux]
> Error 2 make[1]: Leaving directory `/usr/src/linux-2.6.29'
> make: *** [all] Error 2
>
>
> Cheers,
>
> Zhiyong Wu
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: The errors appear when compiling kvm-guest-drivers on kernel-2.6.29

[Avi Kivity]

Brian Jackson wrote:
> I don't think the kvm-guest-drivers are still well maintained (they haven't 
> been touched in 5 months). If you are using kernel 2.6.29, it already has 
> virtio drivers and you don't need the kvm-guest-drivers tree at all.
>   

That is correct.  The effort to maintain a network driver portable to 
more than 10 kernel versions is too great.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.