All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@grandegger.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, Scott Wood <scottwood@freescale.com>
Subject: Re: powerpc/85xx: Add support for the "socrates" board (MPC8544)
Date: Thu, 02 Apr 2009 20:50:56 +0200	[thread overview]
Message-ID: <49D50910.4020909@grandegger.com> (raw)
In-Reply-To: <3247527D-1FD0-420F-99C6-9DADBB79B020@kernel.crashing.org>

Kumar Gala wrote:
> 
> On Apr 2, 2009, at 1:38 AM, Wolfgang Grandegger wrote:
> 
>>
>> Socrates is a new board and it has no problem using an up-to-date
>> version of U-Boot. The socrates.dts file in your "next" tree already has
>> the "device_type = "soc" removed. We need to add "fsl,soc" to the
>> "compatible" property and update fsl_get_sys_freq(), etc. to search for
>> it as well. And U-Boot should use the same name to fixup the
>> frequencies. Are you already working on that issue? Should I provide
>> patches?
>>
> 
> I'm not working on it at all.  I'm also guessing at this point the
> Socrates support is in Linus tree :)

Yes, I know, but it does not work properly because the "device_type =
"soc" is missing :-(. I did not realize that immediately, sorry. Could
you please apply the fix below re-adding the 'device_type = "soc";' line
for the time being.

Thanks.

Wolfgang.


[PATCH] powerpc/85xx: Re-add the device_type soc to socrates.dts

The device_type "soc" is still required for MPC85xx boards.

Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
---
 arch/powerpc/boot/dts/socrates.dts |    1 +
 1 file changed, 1 insertion(+)

Index: powerpc/arch/powerpc/boot/dts/socrates.dts
===================================================================
--- powerpc.orig/arch/powerpc/boot/dts/socrates.dts	2009-04-01
15:26:09.000000000 +0200
+++ powerpc/arch/powerpc/boot/dts/socrates.dts	2009-04-02
16:37:09.838719521 +0200
@@ -52,6 +52,7 @@
 	soc8544@e0000000 {
 		#address-cells = <1>;
 		#size-cells = <1>;
+		device_type = "soc";

 		ranges = <0x00000000 0xe0000000 0x00100000>;
 		reg = <0xe0000000 0x00001000>;	// CCSRBAR 1M

  reply	other threads:[~2009-04-02 18:51 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-19 15:26 powerpc/85xx: Add support for the "socrates" board (MPC8544) Wolfgang Grandegger
2009-03-20  4:10 ` David Gibson
2009-03-20 20:12   ` Wolfgang Grandegger
2009-03-20 22:02   ` Wolfgang Grandegger
2009-03-20  4:26 ` Kumar Gala
2009-03-20 20:16   ` Wolfgang Grandegger
2009-03-20  5:05 ` Grant Likely
2009-03-20 11:57   ` Wolfgang Grandegger
2009-03-31  9:35   ` Wolfgang Grandegger
2009-03-31 13:23     ` Grant Likely
2009-03-31 13:36       ` Wolfgang Grandegger
2009-03-31 15:05         ` Grant Likely
2009-03-31 15:54           ` Anton Vorontsov
2009-03-31 16:02             ` Grant Likely
2009-04-01  7:36             ` Wolfgang Grandegger
2009-04-01 12:40               ` Grant Likely
2009-04-01 13:10                 ` Wolfgang Grandegger
2009-04-01 13:27                   ` Kumar Gala
2009-04-01 13:49                     ` Grant Likely
2009-04-02  6:38                     ` Wolfgang Grandegger
2009-04-02 13:47                       ` Kumar Gala
2009-04-02 18:50                         ` Wolfgang Grandegger [this message]
2009-04-02 19:52                           ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49D50910.4020909@grandegger.com \
    --to=wg@grandegger.com \
    --cc=galak@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.