From: Avi Kivity <avi@redhat.com>
To: kvm-ia64@vger.kernel.org
Subject: Re: [PATCH] KVM: Qemu: Flush i-cache after ide-dma operation in IA64
Date: Fri, 03 Apr 2009 11:06:11 +0000 [thread overview]
Message-ID: <49D5EDA3.7060709@redhat.com> (raw)
In-Reply-To: <10C63FAD690C13458F0B32BCED571F140F98ED4B@pdsmsx502.ccr.corp.intel.com>
Zhang, Xiantao wrote:
>> This is the wrong place to put this. Once we stop bouncing
>> scatter/gather DMA, we will no longer call this function.
>>
>
> This patch intends to fix the issue before adopting scatter/gather DMA mode. But if we want to keep this funtion, had better to pick it to avoid such issues in future.
>
>
This function is the wrong place, it just happens to be called.
>> The correct place is either in the device code itself, or in the dma
>> api (dma-helpers.c).
>>
>
> Maybe dma-helpers.c
Please send a patch with this in dma-helpers.c.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: "Zhang, Xiantao" <xiantao.zhang@intel.com>
Cc: "Zhang, Yang" <yang.zhang@intel.com>,
"kvm-ia64@vger.kernel.org" <kvm-ia64@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: Qemu: Flush i-cache after ide-dma operation in IA64
Date: Fri, 03 Apr 2009 14:06:11 +0300 [thread overview]
Message-ID: <49D5EDA3.7060709@redhat.com> (raw)
In-Reply-To: <706158FABBBA044BAD4FE898A02E4BC2326A0CC6@pdsmsx503.ccr.corp.intel.com>
Zhang, Xiantao wrote:
>> This is the wrong place to put this. Once we stop bouncing
>> scatter/gather DMA, we will no longer call this function.
>>
>
> This patch intends to fix the issue before adopting scatter/gather DMA mode. But if we want to keep this funtion, had better to pick it to avoid such issues in future.
>
>
This function is the wrong place, it just happens to be called.
>> The correct place is either in the device code itself, or in the dma
>> api (dma-helpers.c).
>>
>
> Maybe dma-helpers.c
Please send a patch with this in dma-helpers.c.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2009-04-03 11:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-02 2:01 [PATCH] KVM: Qemu: Flush i-cache after ide-dma operation in IA64 Zhang, Yang
2009-04-02 2:01 ` Zhang, Yang
2009-04-02 8:55 ` Avi Kivity
2009-04-02 8:55 ` Avi Kivity
2009-04-02 15:41 ` tgingold
2009-04-02 15:41 ` tgingold
2009-04-02 15:53 ` Avi Kivity
2009-04-02 15:53 ` Avi Kivity
2009-04-02 15:59 ` Avi Kivity
2009-04-02 15:59 ` Avi Kivity
2009-04-03 1:13 ` Zhang, Xiantao
2009-04-03 1:13 ` Zhang, Xiantao
2009-04-03 1:22 ` Zhang, Xiantao
2009-04-03 1:22 ` Zhang, Xiantao
2009-04-03 1:31 ` Zhang, Xiantao
2009-04-03 1:31 ` Zhang, Xiantao
2009-04-03 11:06 ` Avi Kivity [this message]
2009-04-03 11:06 ` Avi Kivity
2009-04-06 16:31 ` [PATCH] KVM: Qemu: Flush i-cache after ide-dma operation in Hollis Blanchard
2009-04-06 16:31 ` [PATCH] KVM: Qemu: Flush i-cache after ide-dma operation in IA64 Hollis Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D5EDA3.7060709@redhat.com \
--to=avi@redhat.com \
--cc=kvm-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.