From: Anthony Liguori <aliguori@us.ibm.com>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [PATCH] Fix display breakage when resizing the screen (v2)
Date: Sun, 05 Apr 2009 13:45:37 -0500 [thread overview]
Message-ID: <49D8FC51.3010709@us.ibm.com> (raw)
In-Reply-To: <1238945808-13027-1-git-send-email-avi@redhat.com>
Avi Kivity wrote:
> When the vga resolution changes, a new display surface is not allocated
> immediately; instead that is deferred until the next update. However,
> if we're running without a display client attached, that won't happen
> and the next bitblt is likely to cause a segfault by overflowing the
> display surface.
>
> Fix by reallocating the display immediately when the resolution changes.
>
> Tested with (Windows|Linux) x (cirrus|std) x (curses|sdl).
>
> Changes from v1:
> - fix segfault when switching virtual consoles with curses
>
> Signed-off-by: Avi Kivity <avi@redhat.com>
>
Applied. Thanks.
--
Regards,
Anthony Liguori
WARNING: multiple messages have this Message-ID (diff)
From: Anthony Liguori <aliguori@us.ibm.com>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: [Qemu-devel] Re: [PATCH] Fix display breakage when resizing the screen (v2)
Date: Sun, 05 Apr 2009 13:45:37 -0500 [thread overview]
Message-ID: <49D8FC51.3010709@us.ibm.com> (raw)
In-Reply-To: <1238945808-13027-1-git-send-email-avi@redhat.com>
Avi Kivity wrote:
> When the vga resolution changes, a new display surface is not allocated
> immediately; instead that is deferred until the next update. However,
> if we're running without a display client attached, that won't happen
> and the next bitblt is likely to cause a segfault by overflowing the
> display surface.
>
> Fix by reallocating the display immediately when the resolution changes.
>
> Tested with (Windows|Linux) x (cirrus|std) x (curses|sdl).
>
> Changes from v1:
> - fix segfault when switching virtual consoles with curses
>
> Signed-off-by: Avi Kivity <avi@redhat.com>
>
Applied. Thanks.
--
Regards,
Anthony Liguori
next prev parent reply other threads:[~2009-04-05 18:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-05 15:36 [PATCH] Fix display breakage when resizing the screen (v2) Avi Kivity
2009-04-05 15:36 ` [Qemu-devel] " Avi Kivity
2009-04-05 18:45 ` Anthony Liguori [this message]
2009-04-05 18:45 ` [Qemu-devel] " Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D8FC51.3010709@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.