All of lore.kernel.org
 help / color / mirror / Atom feed
From: phcoder <phcoder@gmail.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Video mode fixes in linux loader
Date: Tue, 07 Apr 2009 09:31:57 +0200	[thread overview]
Message-ID: <49DB016D.1070000@gmail.com> (raw)
In-Reply-To: <1239065374.15621.202.camel@mj>

Does it actually work? I don't see the code which either handles 
GRUB_LINUX_VID_MODE_ASK or passes it to the kernel. Also it looks like 
vga= parameter is parsed by grub and grub passes only video mode values 
as resolution and color depth. Wouldn't it be better to move to a more 
modern video mode specification method? As gfxpayload variable 
previously discussed on that list
Pavel Roskin wrote:
> On Tue, 2009-04-07 at 09:31 +0900, Yoshinori K. Okuji wrote:
>>> +  free_pages();
>> Please insert a space before the parenthesis.
> 
> Done.
> 
>> This is not due to you, but the comment above is not synchronized with the 
>> code apparently. Can you fix it?
> 
> Fixed and committed.
> 


-- 

Regards
Vladimir 'phcoder' Serbinenko



  reply	other threads:[~2009-04-07  7:32 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-06 15:34 [PATCH] Video mode fixes in linux loader Pavel Roskin
2009-04-07  0:31 ` Yoshinori K. Okuji
2009-04-07  0:49   ` Pavel Roskin
2009-04-07  7:31     ` phcoder [this message]
2009-04-07 22:04       ` Pavel Roskin
2009-04-12 19:11         ` phcoder
2009-04-12 20:43           ` Pavel Roskin
2009-04-13 14:16 ` Robert Millan
2009-04-13 14:45   ` Robert Millan
2009-04-13 15:41     ` Pavel Roskin
2009-04-13 19:05       ` Robert Millan
2009-04-13 23:20         ` Pavel Roskin
2009-04-14  0:02           ` phcoder
2009-05-02 11:38             ` Robert Millan
2009-05-02 11:31           ` Robert Millan
2009-05-02 15:32             ` Robert Millan
2009-05-03  0:03               ` BandiPat
2009-05-03 15:53                 ` Robert Millan
2009-05-04 15:15                   ` BandiPat
2009-05-04 16:01                     ` Robert Millan
2009-05-04 18:16                       ` BandiPat
2009-05-04 18:16                         ` Felix Zielcke
2009-05-04 20:30                   ` Robert Millan
2009-05-04 21:59                     ` BandiPat
2009-05-13 20:47                       ` Robert Millan
2009-05-04 18:04               ` Robert Millan
2009-05-03 13:18             ` Isaac Dupree
2009-05-03 15:50               ` Robert Millan
2009-04-13 15:16   ` Pavel Roskin
2009-04-13 18:59     ` Robert Millan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49DB016D.1070000@gmail.com \
    --to=phcoder@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.