All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miao Xie <miaox@cn.fujitsu.com>
To: Christoph Lameter <cl@linux.com>
Cc: Ingo Molnar <mingo@elte.hu>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Menage <menage@google.com>,
	Nick Piggin <nickpiggin@yahoo.com.au>,
	Linux-Kernel <linux-kernel@vger.kernel.org>,
	Linux-MM <linux-mm@kvack.org>,
	Yasunori Goto <y-goto@jp.fujitsu.com>
Subject: Re: [RFC][PATCH 0/3] cpuset,mm: fix memory spread bug
Date: Wed, 08 Apr 2009 08:56:51 +0800	[thread overview]
Message-ID: <49DBF653.7070101@cn.fujitsu.com> (raw)
In-Reply-To: <alpine.DEB.1.10.0904071703340.12192@qirst.com>

on 2009-4-8 5:04 Christoph Lameter wrote:
> Interesting patch set but I cannot find parts 2 and 3. The locking changes
> get rid of the generation scheme in cpusets which is a good thing if it
> works right.

Sorry for the late reply and my mistake. The following URLs is the patches'
address.

patch 1: restructure the function cpuset_update_task_memory_state()
http://marc.info/?l=linux-kernel&m=123910183705576&w=2

patch 2: update tasks' page/slab spread flags in time
http://marc.info/?l=linux-kernel&m=123910199505770&w=2

patch 3: update tasks' mems_allowed in time
http://marc.info/?l=linux-mm&m=123910199605776&w=2

Thanks
Miao

> 
> On Tue, 7 Apr 2009, Miao Xie wrote:
> 
>> The kernel still allocated the page caches on old node after modifying its
>> cpuset's mems when 'memory_spread_page' was set, or it didn't spread the page
>> cache evenly over all the nodes that faulting task is allowed to usr after
>> memory_spread_page was set. it is caused by the old mem_allowed and flags
>> of the task, the current kernel doesn't updates them unless some function
>> invokes cpuset_update_task_memory_state(), it is too late sometimes.We must
>> update the mem_allowed and the flags of the tasks in time.
>>
>> Slab has the same problem.
>>
>> The following patches fix this bug by updating tasks' mem_allowed and spread
>> flag after its cpuset's mems or spread flag is changed.
>>
>> patch 1: restructure the function cpuset_update_task_memory_state()
>> patch 2: update tasks' page/slab spread flags in time
>> patch 3: update tasks' mems_allowed in time
>>
>>
>> --
>> To unsubscribe, send a message with 'unsubscribe linux-mm' in
>> the body to majordomo@kvack.org.  For more info on Linux MM,
>> see: http://www.linux-mm.org/ .
>> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>>
> 
> 
> 



WARNING: multiple messages have this Message-ID (diff)
From: Miao Xie <miaox@cn.fujitsu.com>
To: Christoph Lameter <cl@linux.com>
Cc: Ingo Molnar <mingo@elte.hu>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Menage <menage@google.com>,
	Nick Piggin <nickpiggin@yahoo.com.au>,
	Linux-Kernel <linux-kernel@vger.kernel.org>,
	Linux-MM <linux-mm@kvack.org>,
	Yasunori Goto <y-goto@jp.fujitsu.com>
Subject: Re: [RFC][PATCH 0/3] cpuset,mm: fix memory spread bug
Date: Wed, 08 Apr 2009 08:56:51 +0800	[thread overview]
Message-ID: <49DBF653.7070101@cn.fujitsu.com> (raw)
In-Reply-To: <alpine.DEB.1.10.0904071703340.12192@qirst.com>

on 2009-4-8 5:04 Christoph Lameter wrote:
> Interesting patch set but I cannot find parts 2 and 3. The locking changes
> get rid of the generation scheme in cpusets which is a good thing if it
> works right.

Sorry for the late reply and my mistake. The following URLs is the patches'
address.

patch 1: restructure the function cpuset_update_task_memory_state()
http://marc.info/?l=linux-kernel&m=123910183705576&w=2

patch 2: update tasks' page/slab spread flags in time
http://marc.info/?l=linux-kernel&m=123910199505770&w=2

patch 3: update tasks' mems_allowed in time
http://marc.info/?l=linux-mm&m=123910199605776&w=2

Thanks
Miao

> 
> On Tue, 7 Apr 2009, Miao Xie wrote:
> 
>> The kernel still allocated the page caches on old node after modifying its
>> cpuset's mems when 'memory_spread_page' was set, or it didn't spread the page
>> cache evenly over all the nodes that faulting task is allowed to usr after
>> memory_spread_page was set. it is caused by the old mem_allowed and flags
>> of the task, the current kernel doesn't updates them unless some function
>> invokes cpuset_update_task_memory_state(), it is too late sometimes.We must
>> update the mem_allowed and the flags of the tasks in time.
>>
>> Slab has the same problem.
>>
>> The following patches fix this bug by updating tasks' mem_allowed and spread
>> flag after its cpuset's mems or spread flag is changed.
>>
>> patch 1: restructure the function cpuset_update_task_memory_state()
>> patch 2: update tasks' page/slab spread flags in time
>> patch 3: update tasks' mems_allowed in time
>>
>>
>> --
>> To unsubscribe, send a message with 'unsubscribe linux-mm' in
>> the body to majordomo@kvack.org.  For more info on Linux MM,
>> see: http://www.linux-mm.org/ .
>> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>>
> 
> 
> 


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2009-04-08  1:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-07 10:52 [RFC][PATCH 0/3] cpuset,mm: fix memory spread bug Miao Xie
2009-04-07 10:52 ` Miao Xie
2009-04-07 21:04 ` Christoph Lameter
2009-04-07 21:04   ` Christoph Lameter
2009-04-08  0:56   ` Miao Xie [this message]
2009-04-08  0:56     ` Miao Xie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49DBF653.7070101@cn.fujitsu.com \
    --to=miaox@cn.fujitsu.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=cl@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=menage@google.com \
    --cc=mingo@elte.hu \
    --cc=nickpiggin@yahoo.com.au \
    --cc=y-goto@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.