All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shen Feng <shen@cn.fujitsu.com>
To: David Miller <davem@davemloft.net>
Cc: bhutchings@solarflare.com, akpm@linux-foundation.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IPv4/IPv6: update sysctl files
Date: Wed, 08 Apr 2009 16:50:49 +0800	[thread overview]
Message-ID: <49DC6569.5030908@cn.fujitsu.com> (raw)
In-Reply-To: <20090408.001828.262566823.davem@davemloft.net>



on 04/08/2009 03:18 PM, David Miller wrote:
> From: Shen Feng <shen@cn.fujitsu.com>
> Date: Wed, 08 Apr 2009 11:28:21 +0800
> 
>>
>> on 04/08/2009 10:47 AM, Ben Hutchings wrote:
>>> On Wed, 2009-04-08 at 02:39 +0000, Shen Feng wrote:
>>>> Now the following sysctl files in /proc/sys/net/ipv4 are used by
>>>> both IPv4 and IPv6.
>>>> tcp_mem  tcp_rmem  tcp_wmem
>>>> udp_mem  udp_rmem_min  udp_wmem_min
>>>> Putting them in /proc/sys/net/ipv4 is not a good choice.
>>> [...]
>>>
>>> But this is part of the ABI to userland.  You cannot remove sysctl files
>>> without long advance notice documented in feature-removal-schedule.txt
>>> (if at all).
>>>
>>> If it is possible to add the paths
>>> /proc/sys/net/{tcp,udp} while retaining aliases under /proc/sys/net/ipv4
>>> then that might be a workable solution.
>> Thanks. That's a good solution.
>>
>> But I'm still confused.
>> Why not create another tcp_mem in /proc/sys/net/ipv6?
> 
> People just need to understand that ipv4 is always going to be
> there and that's where all the tcp controls are.
> 
> I really am not going to entertain changes that try to move generic
> inet sysctl things out of the ipv4 directory.  There is really no
> point at all.
> 

/proc/sys/net/ipv4/tcp_mem is a inet sysctl, but it also controls the tcp v6.
So it's also a inet6 sysctl. Is it intentional?
This may confuse users. We may have a /proc/sys/net/ipv6/tcp6_mem.

> 
> 

  reply	other threads:[~2009-04-08  8:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-08  2:17 [PATCH] IPv4/IPv6: update sysctl files Shen Feng
2009-04-08  2:41 ` Eric W. Biederman
2009-04-08  2:47 ` Ben Hutchings
2009-04-08  3:28   ` Shen Feng
2009-04-08  7:18     ` David Miller
2009-04-08  8:50       ` Shen Feng [this message]
2009-04-08  9:09         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49DC6569.5030908@cn.fujitsu.com \
    --to=shen@cn.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.