From: ebiederm@xmission.com (Eric W. Biederman)
To: Shen Feng <shen@cn.fujitsu.com>
Cc: davem@davemloft.net, Andrew Morton <akpm@linux-foundation.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IPv4/IPv6: update sysctl files
Date: Tue, 07 Apr 2009 19:41:10 -0700 [thread overview]
Message-ID: <m11vs3rho9.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <49DC091C.6070708@cn.fujitsu.com> (Shen Feng's message of "Wed\, 08 Apr 2009 10\:17\:00 +0800")
Shen Feng <shen@cn.fujitsu.com> writes:
> Now the following sysctl files in /proc/sys/net/ipv4 are used by
> both IPv4 and IPv6.
> tcp_mem tcp_rmem tcp_wmem
> udp_mem udp_rmem_min udp_wmem_min
> Putting them in /proc/sys/net/ipv4 is not a good choice.
>
> So move tcp_mem tcp_rmem tcp_wmem to /proc/sys/net/tcp and
> move udp_mem udp_rmem_min udp_wmem_min to /poc/sys/net/udp.
How badly does this blow up when you enable sysctl_check?
You just enabled new binary sysctl mappings, which is big no-no.
Further how many user space scripts did you break that touch those
files? This is an ABI change.
Eric
next prev parent reply other threads:[~2009-04-08 2:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-08 2:17 [PATCH] IPv4/IPv6: update sysctl files Shen Feng
2009-04-08 2:41 ` Eric W. Biederman [this message]
2009-04-08 2:47 ` Ben Hutchings
2009-04-08 3:28 ` Shen Feng
2009-04-08 7:18 ` David Miller
2009-04-08 8:50 ` Shen Feng
2009-04-08 9:09 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m11vs3rho9.fsf@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.