* [PATCH 10/14] lemote: rtc driver binary mode support
@ 2009-04-09 5:06 yanhua
2009-04-09 11:55 ` Sergei Shtylyov
2009-04-13 10:48 ` Zhang Le
0 siblings, 2 replies; 3+ messages in thread
From: yanhua @ 2009-04-09 5:06 UTC (permalink / raw)
To: linux-mips, Ralf Baechle; +Cc: 彭亮锦, zhangfx@lemote.com
The original driver will exit when detect rtc binary mode. In fact both
the binary mode and bcd are supported
---
drivers/rtc/rtc-cmos.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c
index b6d35f5..85c327e 100644
--- a/drivers/rtc/rtc-cmos.c
+++ b/drivers/rtc/rtc-cmos.c
@@ -757,7 +757,7 @@ cmos_do_probe(struct device *dev, struct resource
*ports, int rtc_irq)
* <asm-generic/rtc.h> doesn't know 12-hour mode either.
*/
if (is_valid_irq(rtc_irq) &&
- (!(rtc_control & RTC_24H) || (rtc_control & (RTC_DM_BINARY)))) {
+ (!(rtc_control & RTC_24H) /*|| (rtc_control & (RTC_DM_BINARY))*/)) {
dev_dbg(dev, "only 24-hr BCD mode supported\n");
retval = -ENXIO;
goto cleanup1;
--
1.5.6.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 10/14] lemote: rtc driver binary mode support
2009-04-09 5:06 [PATCH 10/14] lemote: rtc driver binary mode support yanhua
@ 2009-04-09 11:55 ` Sergei Shtylyov
2009-04-13 10:48 ` Zhang Le
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2009-04-09 11:55 UTC (permalink / raw)
To: yanhua
Cc: linux-mips, Ralf Baechle, 彭亮锦,
zhangfx@lemote.com
yanhua wrote:
> The original driver will exit when detect rtc binary mode. In fact both
> the binary mode and bcd are supported
[...]
> diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c
> index b6d35f5..85c327e 100644
> --- a/drivers/rtc/rtc-cmos.c
> +++ b/drivers/rtc/rtc-cmos.c
> @@ -757,7 +757,7 @@ cmos_do_probe(struct device *dev, struct resource
> *ports, int rtc_irq)
> * <asm-generic/rtc.h> doesn't know 12-hour mode either.
> */
> if (is_valid_irq(rtc_irq) &&
> - (!(rtc_control & RTC_24H) || (rtc_control & (RTC_DM_BINARY)))) {
> + (!(rtc_control & RTC_24H) /*|| (rtc_control & (RTC_DM_BINARY))*/)) {
> dev_dbg(dev, "only 24-hr BCD mode supported\n");
Perhaps the message should be changed too then...
> retval = -ENXIO;
> goto cleanup1;
WBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 10/14] lemote: rtc driver binary mode support
2009-04-09 5:06 [PATCH 10/14] lemote: rtc driver binary mode support yanhua
2009-04-09 11:55 ` Sergei Shtylyov
@ 2009-04-13 10:48 ` Zhang Le
1 sibling, 0 replies; 3+ messages in thread
From: Zhang Le @ 2009-04-13 10:48 UTC (permalink / raw)
To: yanhua
Cc: linux-mips, Ralf Baechle, 彭亮锦,
zhangfx@lemote.com
On 13:06 Thu 09 Apr , yanhua wrote:
> if (is_valid_irq(rtc_irq) &&
> - (!(rtc_control & RTC_24H) || (rtc_control & (RTC_DM_BINARY)))) {
> + (!(rtc_control & RTC_24H) /*|| (rtc_control & (RTC_DM_BINARY))*/)) {
Why not just remove this part "/*|| (rtc_control & (RTC_DM_BINARY))*/" ?
> dev_dbg(dev, "only 24-hr BCD mode supported\n");
> retval = -ENXIO;
> goto cleanup1;
Zhang, Le
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-04-13 10:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-09 5:06 [PATCH 10/14] lemote: rtc driver binary mode support yanhua
2009-04-09 11:55 ` Sergei Shtylyov
2009-04-13 10:48 ` Zhang Le
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.