All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Jeff Garzik <jeff@garzik.org>, linux-ide@vger.kernel.org
Subject: Re: [PROPOSED] ata: Report 16/32bit PIO as best we can
Date: Thu, 09 Apr 2009 06:48:06 -0700	[thread overview]
Message-ID: <49DDFC96.7090305@kernel.org> (raw)
In-Reply-To: <20090409144110.34654dd9@lxorguk.ukuu.org.uk>

Alan Cox wrote:
>> Thus 'set' has always been an illusion for libata.  It's really been 
>> read-only.
> 
> Which nicely solves the flags2 problem - we have flags, and we have
> dynamic flags and if we move the other changing flags into dynflags over
> time all will be happy.

Umm... there's already ap->pflags for the purpose and it was splitted
out for exactly the same reason.  If we're running out of flags space,
I think we better switch to bitfields than introducing flagsN and
risking testing/setting the wrong flag to the wrong field.

Thanks.

-- 
tejun

  parent reply	other threads:[~2009-04-09 13:48 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-09 13:32 [PROPOSED] ata: Report 16/32bit PIO as best we can Alan Cox
2009-04-09 12:50 ` Jeff Garzik
2009-04-09 12:53   ` Alan Cox
2009-04-09 13:08     ` Jeff Garzik
2009-04-09 13:12       ` Alan Cox
2009-04-09 13:33         ` Jeff Garzik
2009-04-09 13:41           ` Alan Cox
2009-04-09 13:45             ` Jeff Garzik
2009-04-09 13:48             ` Tejun Heo [this message]
2009-04-09 13:49               ` Tejun Heo
2009-04-09 13:45         ` Tejun Heo
2009-04-09 13:58           ` Alan Cox
2009-04-09 14:02             ` Tejun Heo
2009-04-09 13:02 ` Mark Lord
2009-04-09 13:08   ` Alan Cox
2009-04-13 16:32     ` Jeff Garzik
2009-04-13 16:39       ` Alan Cox
2009-04-13 16:57         ` Jeff Garzik
2009-04-09 13:25   ` Jeff Garzik
2009-04-09 16:57     ` Mark Lord
2009-04-09 20:42       ` Jeff Garzik
2009-04-10  0:38     ` Douglas Gilbert
2009-04-10  0:47       ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49DDFC96.7090305@kernel.org \
    --to=tj@kernel.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.