[Xenomai-core] Git pull request.

[Xenomai-core] Git pull request.

[Gilles Chanteperdrix]

Hi Philippe,

I got some changes ready for head. What we want to include in the stable
branch remains to be discussed, once we agree, I will prepare another
branch for v2.4.x patches.

The following changes since commit bbbaec33689d8e82b604745bb55209a83d79a4bc:
  Philippe Gerum (1):
        Test for self-deletion in a safer way

are available in the git repository at:

  git://git.xenomai.org/xenomai-gch.git for-upstream

Gilles Chanteperdrix (4):
      Improve switchtest coverage.
      x86 FPU fixes
      Optimize x86 fpu switches.
      Fix rt_task_trampoline and rt_task_shadow error paths.

 include/asm-arm/fptest.h              |   14 +-
 include/asm-blackfin/fptest.h         |   10 +
 include/asm-powerpc/fptest.h          |   34 +++
 include/asm-x86/bits/pod_32.h         |   41 ++---
 include/asm-x86/bits/pod_64.h         |   39 ++--
 include/asm-x86/fptest.h              |   31 +++
 include/rtdm/rttesting.h              |    8 +-
 ksrc/drivers/testing/switchtest.c     |  385
+++++++++++++++++++++------------
 src/skins/native/task.c               |   43 +++--
 src/testsuite/switchtest/switchtest.c |  239 ++++++++++++++------
 10 files changed, 567 insertions(+), 277 deletions(-)

-- 
                                                 Gilles.

Re: [Xenomai-core] Git pull request.

[Philippe Gerum]

On Fri, 2009-04-10 at 11:23 +0200, Gilles Chanteperdrix wrote:
> Hi Philippe,
> 
> I got some changes ready for head. What we want to include in the stable
> branch remains to be discussed, once we agree, I will prepare another
> branch for v2.4.x patches.
> 

No objection to merge back FPU fixes to 2.4.x before we close that
branch, when 2.5 is out. This would give us some time to make sure
everything is fine while running the -rc series.

> The following changes since commit bbbaec33689d8e82b604745bb55209a83d79a4bc:
>   Philippe Gerum (1):
>         Test for self-deletion in a safer way
> 
> are available in the git repository at:
> 
>   git://git.xenomai.org/xenomai-gch.git for-upstream
> 
> Gilles Chanteperdrix (4):
>       Improve switchtest coverage.
>       x86 FPU fixes
>       Optimize x86 fpu switches.
>       Fix rt_task_trampoline and rt_task_shadow error paths.

I'm generally ok with the patches, but the last one still leaves an
issue open: if the child thread dies upon -ENOMEM, the creator won't be
unblocked from pending on the completion sync in rt_task_create(). We
could live with this for a while (lacking memory at that point is a
clear sign that things are going to turn ugly very soon anyway), but
would we want to fix this, we would have to either fire the
__rt_task_create syscall with some NULL args and let it notice them,
then signal the completion block with an error status, or have something
like __xn_sys_sigcompletion to unblock the waiter directly from
userland.

> 
>  include/asm-arm/fptest.h              |   14 +-
>  include/asm-blackfin/fptest.h         |   10 +
>  include/asm-powerpc/fptest.h          |   34 +++
>  include/asm-x86/bits/pod_32.h         |   41 ++---
>  include/asm-x86/bits/pod_64.h         |   39 ++--
>  include/asm-x86/fptest.h              |   31 +++
>  include/rtdm/rttesting.h              |    8 +-
>  ksrc/drivers/testing/switchtest.c     |  385
> +++++++++++++++++++++------------
>  src/skins/native/task.c               |   43 +++--
>  src/testsuite/switchtest/switchtest.c |  239 ++++++++++++++------
>  10 files changed, 567 insertions(+), 277 deletions(-)
> 
-- 
Philippe.

Re: [Xenomai-core] Git pull request.

[Gilles Chanteperdrix]

Philippe Gerum wrote:
> On Fri, 2009-04-10 at 11:23 +0200, Gilles Chanteperdrix wrote:
>> Hi Philippe,
>>
>> I got some changes ready for head. What we want to include in the stable
>> branch remains to be discussed, once we agree, I will prepare another
>> branch for v2.4.x patches.
>>
> 
> No objection to merge back FPU fixes to 2.4.x before we close that
> branch, when 2.5 is out. This would give us some time to make sure
> everything is fine while running the -rc series.

Ok. I was thinking that it may be dangerous to merge the "Optimize x86
fpu switches" patch, since it is not strictly necessary. But from the
point of view of getting it tested ASAP by users, you are right. The
concern about switchtest is that the changes once again break the driver
ABI.

> 
>> The following changes since commit bbbaec33689d8e82b604745bb55209a83d79a4bc:
>>   Philippe Gerum (1):
>>         Test for self-deletion in a safer way
>>
>> are available in the git repository at:
>>
>>   git://git.xenomai.org/xenomai-gch.git for-upstream
>>
>> Gilles Chanteperdrix (4):
>>       Improve switchtest coverage.
>>       x86 FPU fixes
>>       Optimize x86 fpu switches.
>>       Fix rt_task_trampoline and rt_task_shadow error paths.
> 
> I'm generally ok with the patches, but the last one still leaves an
> issue open: if the child thread dies upon -ENOMEM, the creator won't be
> unblocked from pending on the completion sync in rt_task_create(). We
> could live with this for a while (lacking memory at that point is a
> clear sign that things are going to turn ugly very soon anyway), but
> would we want to fix this, we would have to either fire the
> __rt_task_create syscall with some NULL args and let it notice them,
> then signal the completion block with an error status, or have something
> like __xn_sys_sigcompletion to unblock the waiter directly from
> userland.

I just reused the "fail" label of rt_task_trampoline without thinking
about the consequences. Will try to see which idea is simpler to
implement. In any case, I am afraid we will get yet another ABI change.

A question about git now: can I "git reset" or "git branch -D" a remote
branch ?

-- 
                                                 Gilles.

Re: [Xenomai-core] Git pull request.

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 2611 bytes --]

Gilles Chanteperdrix wrote:
> Philippe Gerum wrote:
>> On Fri, 2009-04-10 at 11:23 +0200, Gilles Chanteperdrix wrote:
>>> Hi Philippe,
>>>
>>> I got some changes ready for head. What we want to include in the stable
>>> branch remains to be discussed, once we agree, I will prepare another
>>> branch for v2.4.x patches.
>>>
>> No objection to merge back FPU fixes to 2.4.x before we close that
>> branch, when 2.5 is out. This would give us some time to make sure
>> everything is fine while running the -rc series.
> 
> Ok. I was thinking that it may be dangerous to merge the "Optimize x86
> fpu switches" patch, since it is not strictly necessary. But from the
> point of view of getting it tested ASAP by users, you are right. The
> concern about switchtest is that the changes once again break the driver
> ABI.
> 
>>> The following changes since commit bbbaec33689d8e82b604745bb55209a83d79a4bc:
>>>   Philippe Gerum (1):
>>>         Test for self-deletion in a safer way
>>>
>>> are available in the git repository at:
>>>
>>>   git://git.xenomai.org/xenomai-gch.git for-upstream
>>>
>>> Gilles Chanteperdrix (4):
>>>       Improve switchtest coverage.
>>>       x86 FPU fixes
>>>       Optimize x86 fpu switches.
>>>       Fix rt_task_trampoline and rt_task_shadow error paths.
>> I'm generally ok with the patches, but the last one still leaves an
>> issue open: if the child thread dies upon -ENOMEM, the creator won't be
>> unblocked from pending on the completion sync in rt_task_create(). We
>> could live with this for a while (lacking memory at that point is a
>> clear sign that things are going to turn ugly very soon anyway), but
>> would we want to fix this, we would have to either fire the
>> __rt_task_create syscall with some NULL args and let it notice them,
>> then signal the completion block with an error status, or have something
>> like __xn_sys_sigcompletion to unblock the waiter directly from
>> userland.
> 
> I just reused the "fail" label of rt_task_trampoline without thinking
> about the consequences. Will try to see which idea is simpler to
> implement. In any case, I am afraid we will get yet another ABI change.
> 
> A question about git now: can I "git reset" or "git branch -D" a remote
> branch ?

Just add '-f' to your push command if you have dropped or updated some
patch that is already present in the remote repos (I'm always doing this
when pushing my stgit-managed patch queues).

Deleting a branch remotely is something I haven't tried yet, but the
examples in 'man git-push' claim it works.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]

Re: [Xenomai-core] Git pull request.

[Philippe Gerum]

On Fri, 2009-04-10 at 14:08 +0200, Gilles Chanteperdrix wrote:
> Philippe Gerum wrote:
> > On Fri, 2009-04-10 at 11:23 +0200, Gilles Chanteperdrix wrote:
> >> Hi Philippe,
> >>
> >> I got some changes ready for head. What we want to include in the stable
> >> branch remains to be discussed, once we agree, I will prepare another
> >> branch for v2.4.x patches.
> >>
> > 
> > No objection to merge back FPU fixes to 2.4.x before we close that
> > branch, when 2.5 is out. This would give us some time to make sure
> > everything is fine while running the -rc series.
> 
> Ok. I was thinking that it may be dangerous to merge the "Optimize x86
> fpu switches" patch, since it is not strictly necessary. But from the
> point of view of getting it tested ASAP by users, you are right. The
> concern about switchtest is that the changes once again break the driver
> ABI.
> 

I was only referring to the x86-FPU-fixes patch for a merge back to
2.4.x, benefiting from more testing from the 2.5-rc series. The rest
looks like 2.5 business only.

> > 
> >> The following changes since commit bbbaec33689d8e82b604745bb55209a83d79a4bc:
> >>   Philippe Gerum (1):
> >>         Test for self-deletion in a safer way
> >>
> >> are available in the git repository at:
> >>
> >>   git://git.xenomai.org/xenomai-gch.git for-upstream
> >>
> >> Gilles Chanteperdrix (4):
> >>       Improve switchtest coverage.
> >>       x86 FPU fixes
> >>       Optimize x86 fpu switches.
> >>       Fix rt_task_trampoline and rt_task_shadow error paths.
> > 
> > I'm generally ok with the patches, but the last one still leaves an
> > issue open: if the child thread dies upon -ENOMEM, the creator won't be
> > unblocked from pending on the completion sync in rt_task_create(). We
> > could live with this for a while (lacking memory at that point is a
> > clear sign that things are going to turn ugly very soon anyway), but
> > would we want to fix this, we would have to either fire the
> > __rt_task_create syscall with some NULL args and let it notice them,
> > then signal the completion block with an error status, or have something
> > like __xn_sys_sigcompletion to unblock the waiter directly from
> > userland.
> 
> I just reused the "fail" label of rt_task_trampoline without thinking
> about the consequences. Will try to see which idea is simpler to
> implement. In any case, I am afraid we will get yet another ABI change.
> 
> A question about git now: can I "git reset" or "git branch -D" a remote
> branch ?
> 
-- 
Philippe.

Re: [Xenomai-core] Git pull request.

[Gilles Chanteperdrix]

Philippe Gerum wrote:
> On Fri, 2009-04-10 at 11:23 +0200, Gilles Chanteperdrix wrote:
>> Hi Philippe,
>>
>> I got some changes ready for head. What we want to include in the stable
>> branch remains to be discussed, once we agree, I will prepare another
>> branch for v2.4.x patches.
>>
> 
> No objection to merge back FPU fixes to 2.4.x before we close that
> branch, when 2.5 is out. This would give us some time to make sure
> everything is fine while running the -rc series.
> 
>> The following changes since commit bbbaec33689d8e82b604745bb55209a83d79a4bc:
>>   Philippe Gerum (1):
>>         Test for self-deletion in a safer way
>>
>> are available in the git repository at:
>>
>>   git://git.xenomai.org/xenomai-gch.git for-upstream
>>
>> Gilles Chanteperdrix (4):
>>       Improve switchtest coverage.
>>       x86 FPU fixes
>>       Optimize x86 fpu switches.
>>       Fix rt_task_trampoline and rt_task_shadow error paths.
> 
> I'm generally ok with the patches, but the last one still leaves an
> issue open: if the child thread dies upon -ENOMEM, the creator won't be
> unblocked from pending on the completion sync in rt_task_create(). We
> could live with this for a while (lacking memory at that point is a
> clear sign that things are going to turn ugly very soon anyway), but
> would we want to fix this, we would have to either fire the
> __rt_task_create syscall with some NULL args and let it notice them,
> then signal the completion block with an error status, or have something
> like __xn_sys_sigcompletion to unblock the waiter directly from
> userland.

Ok. The new branch for-head should contain an implementation of the 
first idea. From now on, my proposed fixes should go in that branch.
Fixes for the 2.4 branch should go in the for-2.4 branch.

The following changes since commit 9a9c8bbcc5a5439396d593b250510d89a1584957:
  Philippe Gerum (1):
        Update baseline information

are available in the git repository at:

  git://git.xenomai.org/xenomai-gch.git for-head

Gilles Chanteperdrix (5):
      Improve switchtest coverage.
      x86 FPU fixes
      Optimize x86 fpu switches.
      Fix rt_task_shadow error paths.
      Fix rt_task_trampoline error path.

 include/asm-arm/fptest.h              |   14 +-
 include/asm-blackfin/fptest.h         |   10 +
 include/asm-powerpc/fptest.h          |   34 +++
 include/asm-x86/bits/pod_32.h         |   41 ++---
 include/asm-x86/bits/pod_64.h         |   39 ++--
 include/asm-x86/fptest.h              |   31 +++
 include/rtdm/rttesting.h              |    8 +-
 ksrc/drivers/testing/switchtest.c     |  385 +++++++++++++++++++++------------
 ksrc/skins/native/syscall.c           |    5 +
 src/skins/native/task.c               |   55 +++--
 src/testsuite/switchtest/switchtest.c |  239 ++++++++++++++------
 11 files changed, 578 insertions(+), 283 deletions(-)

-- 
					    Gilles.