From: Renato Andreola <renato.andreola@imagos.it>
To: u-boot@lists.denx.de
Subject: [U-Boot] PATCH mtd CFI flash: timeout calculation underflow if imprecise 1kHz timer: fix
Date: Fri, 10 Apr 2009 14:28:59 +0200 [thread overview]
Message-ID: <49DF3B8B.5000508@imagos.it> (raw)
From 6cc63851e5e4c16012d9afad70cedb41b7340de7 Mon Sep 17 00:00:00 2001
From: Renato Andreola <renato.andreola@imagos.it>
Date: Fri, 10 Apr 2009 12:52:55 +0200
Subject: drivers/mtd/cfi_flash: precision and underflow problem in tout
calculation
With old configuration it could happen tout=0 if CONFIG_SYS_HZ<1000
solved using an unsigned long long
---
drivers/mtd/cfi_flash.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/cfi_flash.c b/drivers/mtd/cfi_flash.c
index 175d82a..0aa42a2 100644
--- a/drivers/mtd/cfi_flash.c
+++ b/drivers/mtd/cfi_flash.c
@@ -660,7 +660,9 @@ static int flash_status_check (flash_info_t * info,
flash_sect_t sector,
ulong start;
#if CONFIG_SYS_HZ != 1000
- tout *= CONFIG_SYS_HZ/1000;
+ unsigned long long ull;
+ ull = tout*CONFIG_SYS_HZ + CONFIG_SYS_HZ/2;
+ tout = ull/1000; /* Compute: tout *= CONFIG_SYS_HZ/1000; */
#endif
/* Wait for command completion */
--
1.5.5
next reply other threads:[~2009-04-10 12:28 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-10 12:28 Renato Andreola [this message]
2009-04-13 22:09 ` [U-Boot] PATCH mtd CFI flash: timeout calculation underflow if imprecise 1kHz timer: fix Jean-Christophe PLAGNIOL-VILLARD
-- strict thread matches above, loose matches on Subject: below --
2009-08-06 9:49 Renato Andreola
2009-08-06 10:07 ` Wolfgang Denk
2009-08-06 10:12 ` Alessandro Rubini
[not found] ` <4A7AB614.2020509@imagos.it>
2009-08-06 11:40 ` Wolfgang Denk
2009-08-06 13:09 Renato Andreola
2009-08-06 13:22 ` Wolfgang Denk
2009-08-06 13:31 ` Alessandro Rubini
2009-08-06 14:19 ` Wolfgang Denk
2009-08-06 20:26 ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-06 20:53 ` Wolfgang Denk
2009-08-06 21:01 ` Wolfgang Denk
2009-08-06 21:15 ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-06 21:35 ` Wolfgang Denk
2009-08-07 8:15 ` Renato Andreola
2009-08-07 9:16 ` Wolfgang Denk
2009-08-07 12:14 ` Renato Andreola
2009-08-09 21:13 ` Wolfgang Denk
2009-08-06 16:08 Renato Andreola
2009-08-24 8:32 Renato Andreola
2009-08-25 13:25 ` Shinya Kuribayashi
2009-08-25 15:01 ` Renato Andreola
2009-08-25 15:39 ` Stefan Roese
2009-08-25 15:44 ` Stefan Roese
2009-11-22 21:09 ` Wolfgang Denk
2009-11-23 8:51 ` Renato Andreola
2009-11-23 19:36 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49DF3B8B.5000508@imagos.it \
--to=renato.andreola@imagos.it \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.