From: Renato Andreola <renato.andreola@imagos.it>
To: u-boot@lists.denx.de
Subject: [U-Boot] PATCH mtd CFI flash: timeout calculation underflow if imprecise 1kHz timer: fix
Date: Thu, 06 Aug 2009 11:49:32 +0200 [thread overview]
Message-ID: <4A7AA72C.8010704@imagos.it> (raw)
From be54cb97ca26bcbbc1a908d1f2a5447b6639dc59 Mon Sep 17 00:00:00 2001
From: Renato Andreola <renato.andreola@imagos.it>
Date: Thu, 6 Aug 2009 11:40:52 +0200
Subject: [PATCH] drivers/mtd/cfi_flash: precision and underflow problem
in tout calculation
With old configuration it could happen tout=0 if CONFIG_SYS_HZ<1000
solved using an unsigned long long
Signed-off-by: Renato Andreola renato.andreola@imagos.it
---
drivers/mtd/cfi_flash.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/cfi_flash.c b/drivers/mtd/cfi_flash.c
index 81ac5d3..6bcd102 100644
--- a/drivers/mtd/cfi_flash.c
+++ b/drivers/mtd/cfi_flash.c
@@ -659,8 +659,10 @@ static int flash_status_check (flash_info_t * info,
flash_sect_t sector,
{
ulong start;
-#if CONFIG_SYS_HZ != 1000
- tout *= CONFIG_SYS_HZ/1000;
+#if CONFIG_SYS_HZ != 1000
+ unsigned long long ull;
+ ull = tout*CONFIG_SYS_HZ + CONFIG_SYS_HZ/2;
+ tout = ull/1000; /* Compute: tout *= CONFIG_SYS_HZ/1000; */
#endif
/* Wait for command completion */
--
1.5.5
next reply other threads:[~2009-08-06 9:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-06 9:49 Renato Andreola [this message]
2009-08-06 10:07 ` [U-Boot] PATCH mtd CFI flash: timeout calculation underflow if imprecise 1kHz timer: fix Wolfgang Denk
2009-08-06 10:12 ` Alessandro Rubini
[not found] ` <4A7AB614.2020509@imagos.it>
2009-08-06 11:40 ` Wolfgang Denk
-- strict thread matches above, loose matches on Subject: below --
2009-08-24 8:32 Renato Andreola
2009-08-25 13:25 ` Shinya Kuribayashi
2009-08-25 15:01 ` Renato Andreola
2009-08-25 15:39 ` Stefan Roese
2009-08-25 15:44 ` Stefan Roese
2009-11-22 21:09 ` Wolfgang Denk
2009-11-23 8:51 ` Renato Andreola
2009-11-23 19:36 ` Wolfgang Denk
2009-08-06 16:08 Renato Andreola
2009-08-06 13:09 Renato Andreola
2009-08-06 13:22 ` Wolfgang Denk
2009-08-06 13:31 ` Alessandro Rubini
2009-08-06 14:19 ` Wolfgang Denk
2009-08-06 20:26 ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-06 20:53 ` Wolfgang Denk
2009-08-06 21:01 ` Wolfgang Denk
2009-08-06 21:15 ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-06 21:35 ` Wolfgang Denk
2009-08-07 8:15 ` Renato Andreola
2009-08-07 9:16 ` Wolfgang Denk
2009-08-07 12:14 ` Renato Andreola
2009-08-09 21:13 ` Wolfgang Denk
2009-04-10 12:28 Renato Andreola
2009-04-13 22:09 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A7AA72C.8010704@imagos.it \
--to=renato.andreola@imagos.it \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.