[PATCH] remove BSD partition number from install_drive/grub_drive in grub-install

[PATCH] remove BSD partition number from install_drive/grub_drive in grub-install

[Felix Zielcke]

[-- Attachment #1: Type: text/plain, Size: 427 bytes --]

Hi,

on BSD grub-install thinks that you're wanting to do a cross-install
when in fact you won't.
The problem is that in install_drive the BSD partition number isn't
removed before doing the cross-install check.
I'm not sure if the regexp is okay so or if it could be better, but at
least it works for me.
Though then grub-install still fails with `grub-setup: error: cannot
open `/dev/da0' in open_device()'
-- 
Felix Zielcke

[-- Attachment #2: remove_bsd_partnumber.diff --]
[-- Type: text/x-patch, Size: 965 bytes --]

2009-04-12  Felix Zielcke  <fzielcke@z-51.de>

	* util/i386/pc/grub-install.in (install_drive): Remove the BSD
	partition number.
	(grub_drive): Likewise.

Index: util/i386/pc/grub-install.in
===================================================================
--- util/i386/pc/grub-install.in	(revision 2083)
+++ util/i386/pc/grub-install.in	(working copy)
@@ -262,8 +262,8 @@ if [ "x${devabstraction_module}" = "x" ]
     grub_drive="`$grub_probe --target=drive --device ${grub_device}`"
 
     # Strip partition number
-    install_drive="`echo ${install_drive} | sed -e s/,[0-9]*//g`"
-    grub_drive="`echo ${grub_drive} | sed -e s/,[0-9]*//g`"
+    install_drive="`echo ${install_drive} | sed -e s/,[0-9]*[a-z]*//g`"
+    grub_drive="`echo ${grub_drive} | sed -e s/,[0-9]*[a-z]*//g`"
     if [ "${target_cpu}-${platform}" != "i386-pc" ] ; then
         # generic method (used on coreboot)
         uuid="`$grub_probe --target=fs_uuid --device ${grub_device}`"

Re: [PATCH] remove BSD partition number from install_drive/grub_drive in grub-install

[Chip Panarchy]

Which BSD?

On Sun, Apr 12, 2009 at 7:52 AM, Felix Zielcke <fzielcke@z-51.de> wrote:
> Hi,
>
> on BSD grub-install thinks that you're wanting to do a cross-install
> when in fact you won't.
> The problem is that in install_drive the BSD partition number isn't
> removed before doing the cross-install check.
> I'm not sure if the regexp is okay so or if it could be better, but at
> least it works for me.
> Though then grub-install still fails with `grub-setup: error: cannot
> open `/dev/da0' in open_device()'
> --
> Felix Zielcke
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
>

Re: [PATCH] remove BSD partition number from install_drive/grub_drive in grub-install

[Felix Zielcke]

Am Sonntag, den 12.04.2009, 09:45 +1000 schrieb Chip Panarchy:
> Which BSD?
> 

Debian GNU/kFreeBSD-amd64
-- 
Felix Zielcke

Re: [PATCH] remove BSD partition number from install_drive/grub_drive in grub-install

[Chip Panarchy]

Hi

Ah, interesting.

I've been trying to get a feature added to GRUB2 to do with
FreeBSD-amd64. That is to give GRUB2 the feature which allows for
direct 'calling' of the 64-bit FreeBSD kernel. GRUB2 currently
supports only the 32-bit version.

If you have the skill, and the time, can you please give a go
implementing the above feature(s)?

Thanks in advance,

Panarchy

On Sun, Apr 12, 2009 at 5:08 PM, Felix Zielcke <fzielcke@z-51.de> wrote:
> Am Sonntag, den 12.04.2009, 09:45 +1000 schrieb Chip Panarchy:
>> Which BSD?
>>
>
> Debian GNU/kFreeBSD-amd64
> --
> Felix Zielcke
>
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>

Re: [PATCH] remove BSD partition number from install_drive/grub_drive in grub-install

[Felix Zielcke]

Am Sonntag, den 12.04.2009, 17:12 +1000 schrieb Chip Panarchy:
> Hi
> 
> Ah, interesting.
> 
> I've been trying to get a feature added to GRUB2 to do with
> FreeBSD-amd64. That is to give GRUB2 the feature which allows for
> direct 'calling' of the 64-bit FreeBSD kernel. GRUB2 currently
> supports only the 32-bit version.

Oh I forgot already that I read this even here that 64bit doestn't work.

> If you have the skill, and the time, can you please give a go
> implementing the above feature(s)?
> 

Well I don't have any experience at all with BSD, I doubt I could figure
this out.

-- 
Felix Zielcke

Re: [PATCH] remove BSD partition number from install_drive/grub_drive in grub-install

[phcoder]

Please, don't bother developers with same request in multiple threads. 
Not only it doesn't help to promote your suggestion but is also 
annoying. I feel it is actually unnice how you push your suggestions 
hardly without offering any help in developement
Chip Panarchy wrote:
> Hi
> 
> Ah, interesting.
> 
> I've been trying to get a feature added to GRUB2 to do with
> FreeBSD-amd64. That is to give GRUB2 the feature which allows for
> direct 'calling' of the 64-bit FreeBSD kernel. GRUB2 currently
> supports only the 32-bit version.
> 
> If you have the skill, and the time, can you please give a go
> implementing the above feature(s)?
> 
> Thanks in advance,
> 
> Panarchy
> 
> On Sun, Apr 12, 2009 at 5:08 PM, Felix Zielcke <fzielcke@z-51.de> wrote:
>> Am Sonntag, den 12.04.2009, 09:45 +1000 schrieb Chip Panarchy:
>>> Which BSD?
>>>
>> Debian GNU/kFreeBSD-amd64
>> --
>> Felix Zielcke
>>
>>
>>
>> _______________________________________________
>> Grub-devel mailing list
>> Grub-devel@gnu.org
>> http://lists.gnu.org/mailman/listinfo/grub-devel
>>
> 
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel


-- 

Regards
Vladimir 'phcoder' Serbinenko

Re: [PATCH] remove BSD partition number from install_drive/grub_drive in grub-install

[Chip Panarchy]

You're right.

Once I have all my operating systems installed, working correctly,
have successfully created my 2 Linux distributions, have some time off
(starting work tomorrow!), then I will learn some C++, and help with
the development of software like GRUB2.

In the meantime, I will have to leech of others... as it were.

Sorry if I am/have sounded rude, that was not my intention.

Please continue helping me out PHcoder.

Thanks in advance,

Panarchy

On Sun, Apr 12, 2009 at 8:39 PM, phcoder <phcoder@gmail.com> wrote:
> Please, don't bother developers with same request in multiple threads. Not
> only it doesn't help to promote your suggestion but is also annoying. I feel
> it is actually unnice how you push your suggestions hardly without offering
> any help in developement
> Chip Panarchy wrote:
>>
>> Hi
>>
>> Ah, interesting.
>>
>> I've been trying to get a feature added to GRUB2 to do with
>> FreeBSD-amd64. That is to give GRUB2 the feature which allows for
>> direct 'calling' of the 64-bit FreeBSD kernel. GRUB2 currently
>> supports only the 32-bit version.
>>
>> If you have the skill, and the time, can you please give a go
>> implementing the above feature(s)?
>>
>> Thanks in advance,
>>
>> Panarchy
>>
>> On Sun, Apr 12, 2009 at 5:08 PM, Felix Zielcke <fzielcke@z-51.de> wrote:
>>>
>>> Am Sonntag, den 12.04.2009, 09:45 +1000 schrieb Chip Panarchy:
>>>>
>>>> Which BSD?
>>>>
>>> Debian GNU/kFreeBSD-amd64
>>> --
>>> Felix Zielcke
>>>
>>>
>>>
>>> _______________________________________________
>>> Grub-devel mailing list
>>> Grub-devel@gnu.org
>>> http://lists.gnu.org/mailman/listinfo/grub-devel
>>>
>>
>>
>> _______________________________________________
>> Grub-devel mailing list
>> Grub-devel@gnu.org
>> http://lists.gnu.org/mailman/listinfo/grub-devel
>
>
> --
>
> Regards
> Vladimir 'phcoder' Serbinenko
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>

Re: [PATCH] remove BSD partition number from install_drive/grub_drive in grub-install

[phcoder]

Hello, I'm sorry if my responses have been a bit rude too.
Chip Panarchy wrote:
> You're right.
> 
> Once I have all my operating systems installed, working correctly,
> have successfully created my 2 Linux distributions, have some time off
> (starting work tomorrow!), then I will learn some C++, and help with
> the development of software like GRUB2.
> 
grub2 doesn't use any C++, only pure C
> Please continue helping me out PHcoder.
You once spoke about xnu code for grub2. I'm happy to announce that this 
code is near its completion. I have some strange bugs in it and some 
incompletenesses but code itself already works
> 
> Thanks in advance,
> 
> Panarchy
> 
> On Sun, Apr 12, 2009 at 8:39 PM, phcoder <phcoder@gmail.com> wrote:
>> Please, don't bother developers with same request in multiple threads. Not
>> only it doesn't help to promote your suggestion but is also annoying. I feel
>> it is actually unnice how you push your suggestions hardly without offering
>> any help in developement
>> Chip Panarchy wrote:
>>> Hi
>>>
>>> Ah, interesting.
>>>
>>> I've been trying to get a feature added to GRUB2 to do with
>>> FreeBSD-amd64. That is to give GRUB2 the feature which allows for
>>> direct 'calling' of the 64-bit FreeBSD kernel. GRUB2 currently
>>> supports only the 32-bit version.
>>>
>>> If you have the skill, and the time, can you please give a go
>>> implementing the above feature(s)?
>>>
>>> Thanks in advance,
>>>
>>> Panarchy
>>>
>>> On Sun, Apr 12, 2009 at 5:08 PM, Felix Zielcke <fzielcke@z-51.de> wrote:
>>>> Am Sonntag, den 12.04.2009, 09:45 +1000 schrieb Chip Panarchy:
>>>>> Which BSD?
>>>>>
>>>> Debian GNU/kFreeBSD-amd64
>>>> --
>>>> Felix Zielcke
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Grub-devel mailing list
>>>> Grub-devel@gnu.org
>>>> http://lists.gnu.org/mailman/listinfo/grub-devel
>>>>
>>>
>>> _______________________________________________
>>> Grub-devel mailing list
>>> Grub-devel@gnu.org
>>> http://lists.gnu.org/mailman/listinfo/grub-devel
>>
>> --
>>
>> Regards
>> Vladimir 'phcoder' Serbinenko
>>
>>
>> _______________________________________________
>> Grub-devel mailing list
>> Grub-devel@gnu.org
>> http://lists.gnu.org/mailman/listinfo/grub-devel
>>
> 
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel


-- 

Regards
Vladimir 'phcoder' Serbinenko

Re: [PATCH] remove BSD partition number from install_drive/grub_drive in grub-install

[Chip Panarchy]

Hello

Great, looking forward to its completion.

Panarchy

On Mon, Apr 13, 2009 at 7:08 PM, phcoder <phcoder@gmail.com> wrote:
> Hello, I'm sorry if my responses have been a bit rude too.
> Chip Panarchy wrote:
>>
>> You're right.
>>
>> Once I have all my operating systems installed, working correctly,
>> have successfully created my 2 Linux distributions, have some time off
>> (starting work tomorrow!), then I will learn some C++, and help with
>> the development of software like GRUB2.
>>
> grub2 doesn't use any C++, only pure C
>>
>> Please continue helping me out PHcoder.
>
> You once spoke about xnu code for grub2. I'm happy to announce that this
> code is near its completion. I have some strange bugs in it and some
> incompletenesses but code itself already works
>>
>> Thanks in advance,
>>
>> Panarchy
>>
>> On Sun, Apr 12, 2009 at 8:39 PM, phcoder <phcoder@gmail.com> wrote:
>>>
>>> Please, don't bother developers with same request in multiple threads.
>>> Not
>>> only it doesn't help to promote your suggestion but is also annoying. I
>>> feel
>>> it is actually unnice how you push your suggestions hardly without
>>> offering
>>> any help in developement
>>> Chip Panarchy wrote:
>>>>
>>>> Hi
>>>>
>>>> Ah, interesting.
>>>>
>>>> I've been trying to get a feature added to GRUB2 to do with
>>>> FreeBSD-amd64. That is to give GRUB2 the feature which allows for
>>>> direct 'calling' of the 64-bit FreeBSD kernel. GRUB2 currently
>>>> supports only the 32-bit version.
>>>>
>>>> If you have the skill, and the time, can you please give a go
>>>> implementing the above feature(s)?
>>>>
>>>> Thanks in advance,
>>>>
>>>> Panarchy
>>>>
>>>> On Sun, Apr 12, 2009 at 5:08 PM, Felix Zielcke <fzielcke@z-51.de> wrote:
>>>>>
>>>>> Am Sonntag, den 12.04.2009, 09:45 +1000 schrieb Chip Panarchy:
>>>>>>
>>>>>> Which BSD?
>>>>>>
>>>>> Debian GNU/kFreeBSD-amd64
>>>>> --
>>>>> Felix Zielcke
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> Grub-devel mailing list
>>>>> Grub-devel@gnu.org
>>>>> http://lists.gnu.org/mailman/listinfo/grub-devel
>>>>>
>>>>
>>>> _______________________________________________
>>>> Grub-devel mailing list
>>>> Grub-devel@gnu.org
>>>> http://lists.gnu.org/mailman/listinfo/grub-devel
>>>
>>> --
>>>
>>> Regards
>>> Vladimir 'phcoder' Serbinenko
>>>
>>>
>>> _______________________________________________
>>> Grub-devel mailing list
>>> Grub-devel@gnu.org
>>> http://lists.gnu.org/mailman/listinfo/grub-devel
>>>
>>
>>
>> _______________________________________________
>> Grub-devel mailing list
>> Grub-devel@gnu.org
>> http://lists.gnu.org/mailman/listinfo/grub-devel
>
>
> --
>
> Regards
> Vladimir 'phcoder' Serbinenko
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>

Re: [PATCH] remove BSD partition number from install_drive/grub_drive in grub-install

[Felix Zielcke]

Am Samstag, den 11.04.2009, 23:52 +0200 schrieb Felix Zielcke:
> Hi,
> 
> on BSD grub-install thinks that you're wanting to do a cross-install
> when in fact you won't.
> The problem is that in install_drive the BSD partition number isn't
> removed before doing the cross-install check.
> I'm not sure if the regexp is okay so or if it could be better, but at
> least it works for me.

I commited this now.
All other variants of the regexp I tried didn't work except that one.
-- 
Felix Zielcke

Re: [PATCH] remove BSD partition number from install_drive/grub_drive in grub-install

[Chip Panarchy]

Awesome.

BTW: How do these update to GRUB2 work, I mean to the patches, once
proven automatically get integrated into GRUB2 (and released to the
official website)?

On Mon, Apr 13, 2009 at 9:44 PM, Felix Zielcke <fzielcke@z-51.de> wrote:
> Am Samstag, den 11.04.2009, 23:52 +0200 schrieb Felix Zielcke:
>> Hi,
>>
>> on BSD grub-install thinks that you're wanting to do a cross-install
>> when in fact you won't.
>> The problem is that in install_drive the BSD partition number isn't
>> removed before doing the cross-install check.
>> I'm not sure if the regexp is okay so or if it could be better, but at
>> least it works for me.
>
> I commited this now.
> All other variants of the regexp I tried didn't work except that one.
> --
> Felix Zielcke
>
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>

Re: [PATCH] remove BSD partition number from install_drive/grub_drive in grub-install

[Joey Korkames]

You can checkout the code via:
svn co svn://svn.savannah.gnu.org/grub/trunk/grub2 

Then use the autocompile.sh 
script that was posted earlier to make builds of grub2 or 
you can wait for the nightly autobuilder to be set-up and just download its 
results (from wherever they will be announced).

GRUB2 is not making frequent stable releases yet.

-joey

 Chip Panarchy writes:

> Awesome.
> 
> BTW: How do these update to GRUB2 work, I mean to the patches, once
> proven automatically get integrated into GRUB2 (and released to the
> official website)?
> 

Re: [PATCH] remove BSD partition number from install_drive/grub_drive in grub-install

[Chip Panarchy]

Hello

Great, thanks.

On Wed, Apr 15, 2009 at 7:40 AM, Joey Korkames <joey+lists@kidfixit.com> wrote:
> You can checkout the code via:
> svn co svn://svn.savannah.gnu.org/grub/trunk/grub2
> Then use the autocompile.sh script that was posted earlier to make builds of
> grub2 or you can wait for the nightly autobuilder to be set-up and just
> download its results (from wherever they will be announced).
>
> GRUB2 is not making frequent stable releases yet.
>
> -joey
>
> Chip Panarchy writes:
>
>> Awesome.
>>
>> BTW: How do these update to GRUB2 work, I mean to the patches, once
>> proven automatically get integrated into GRUB2 (and released to the
>> official website)?
>>
>
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>