From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: kvm-devel <kvm@vger.kernel.org>,
Glauber Costa <glommer@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH] kvm: Fix overlapping check for memory slots
Date: Mon, 13 Apr 2009 12:32:48 +0300 [thread overview]
Message-ID: <49E306C0.1050505@redhat.com> (raw)
In-Reply-To: <49E06754.8050906@web.de>
Jan Kiszka wrote:
> This nice little buglet complicates a smarter slot management in qemu
> user space just "slightly". Sigh...
>
> -------->
>
> When checking for overlapping slots on registration of a new one, kvm
> currently also considers zero-length (ie. deleted) slots and rejects
> requests incorrectly. This finally denies user space from joining slots.
> Fix the check by skipping deleted slots.
>
Can userspace fail gracefully when the bug is present? If not, the you
should add a KVM_CAP_ to advertise the fix; without the capability don't
attempt the smarter slot management.
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Glauber Costa <glommer@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
kvm-devel <kvm@vger.kernel.org>
Subject: [Qemu-devel] Re: [PATCH] kvm: Fix overlapping check for memory slots
Date: Mon, 13 Apr 2009 12:32:48 +0300 [thread overview]
Message-ID: <49E306C0.1050505@redhat.com> (raw)
In-Reply-To: <49E06754.8050906@web.de>
Jan Kiszka wrote:
> This nice little buglet complicates a smarter slot management in qemu
> user space just "slightly". Sigh...
>
> -------->
>
> When checking for overlapping slots on registration of a new one, kvm
> currently also considers zero-length (ie. deleted) slots and rejects
> requests incorrectly. This finally denies user space from joining slots.
> Fix the check by skipping deleted slots.
>
Can userspace fail gracefully when the bug is present? If not, the you
should add a KVM_CAP_ to advertise the fix; without the capability don't
attempt the smarter slot management.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-04-13 9:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-11 9:48 [PATCH] kvm: Fix overlapping check for memory slots Jan Kiszka
2009-04-11 9:48 ` [Qemu-devel] " Jan Kiszka
2009-04-13 5:47 ` Sheng Yang
2009-04-13 5:47 ` [Qemu-devel] " Sheng Yang
2009-04-13 8:50 ` Jan Kiszka
2009-04-13 8:50 ` [Qemu-devel] " Jan Kiszka
2009-04-13 8:53 ` Sheng Yang
2009-04-13 8:53 ` [Qemu-devel] " Sheng Yang
2009-04-13 9:03 ` Jan Kiszka
2009-04-13 9:03 ` [Qemu-devel] " Jan Kiszka
2009-04-13 9:32 ` Avi Kivity [this message]
2009-04-13 9:32 ` Avi Kivity
2009-04-13 9:42 ` Jan Kiszka
2009-04-13 9:42 ` [Qemu-devel] " Jan Kiszka
2009-04-13 9:49 ` Avi Kivity
2009-04-13 9:49 ` [Qemu-devel] " Avi Kivity
2009-04-13 9:59 ` [PATCH v2] " Jan Kiszka
2009-04-13 9:59 ` [Qemu-devel] " Jan Kiszka
2009-04-13 13:04 ` Avi Kivity
2009-04-13 13:04 ` [Qemu-devel] " Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E306C0.1050505@redhat.com \
--to=avi@redhat.com \
--cc=glommer@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.