[PATCH] drivers/regulator: fix when type is different from REGULATOR_VOLTAGE

[PATCH] drivers/regulator: fix when type is different from REGULATOR_VOLTAGE

[Diego Liziero]

From: Diego Liziero <diegoliz@gmail.com>

When regulator_desc->type is something different from REGULATOR_VOLTAGE or REGULATOR_CURRENT
the if should probably return ERR_PTR(-EINVAL)

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

@@ expression E; constant C; @@
(
- !E = C
+ E != C
)

Signed-off-by: Diego Liziero <diegoliz@gmail.com>

---
diff = 
--- ./drivers/regulator/core.c	2009-04-13 01:21:28.000000000 +0200
+++ /tmp/cocci-output-26453-5bbb39-core.c	2009-04-13 20:38:48.000000000 +0200
@@ -2001,8 +2001,8 @@ struct regulator_dev *regulator_register
 	if (regulator_desc->name = NULL || regulator_desc->ops = NULL)
 		return ERR_PTR(-EINVAL);
 
-	if (!regulator_desc->type = REGULATOR_VOLTAGE &&
-	    !regulator_desc->type = REGULATOR_CURRENT)
+	if (regulator_desc->type != REGULATOR_VOLTAGE &&
+	    regulator_desc->type != REGULATOR_CURRENT)
 		return ERR_PTR(-EINVAL);
 
 	if (!init_data)

Re: [PATCH] drivers/regulator: fix when type is different from

[Mark Brown]

On Tue, Apr 14, 2009 at 03:04:47AM +0200, Diego Liziero wrote:

> From: Diego Liziero <diegoliz@gmail.com>
> 
> When regulator_desc->type is something different from REGULATOR_VOLTAGE or REGULATOR_CURRENT
> the if should probably return ERR_PTR(-EINVAL)
> 
> The semantic patch that makes this change is as follows:
> (http://www.emn.fr/x-info/coccinelle/)

Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

Re: [PATCH] drivers/regulator: fix when type is different from

[Liam Girdwood]

On Tue, 2009-04-14 at 03:04 +0200, Diego Liziero wrote:
> From: Diego Liziero <diegoliz@gmail.com>
> 
> When regulator_desc->type is something different from REGULATOR_VOLTAGE or REGULATOR_CURRENT
> the if should probably return ERR_PTR(-EINVAL)
> 
> The semantic patch that makes this change is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
> 
> @@ expression E; constant C; @@
> (
> - !E = C
> + E != C
> )
> 
> Signed-off-by: Diego Liziero <diegoliz@gmail.com>
> 

Applied.

Thanks

Liam