All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
To: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org,
	Dan Smith <danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] Remove READ_IMPLIES_EXEC during restart
Date: Tue, 14 Apr 2009 02:05:00 -0400	[thread overview]
Message-ID: <49E4278C.3060500@cs.columbia.edu> (raw)
In-Reply-To: <49E42646.4040703-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>



Oren Laadan wrote:
> 
> Serge E. Hallyn wrote:
>> Quoting Dan Smith (danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org):
>>> On s390, all tasks have READ_IMPLIES_EXEC set in current->personality,
>>> which causes the restart process to map things like the stack and heap as
>>> executable.  During the restart process, remove this bit and restore the
>>> original personality afterwards.
>>>
>>> This seems a little ugly, but I don't know that there's a better place for
>>> it.
>> Well imo the only other thing to do would be to do the same thing but
>> just around the main restart_memory function.
>>
> 
> I second that. Added.
> 

In fact, if elsewhere we restore current->personality of the task,
then unless we move it to cr_read_mm(), it will overwrite it :(

Oren.

  parent reply	other threads:[~2009-04-14  6:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-06 17:41 [PATCH] Remove READ_IMPLIES_EXEC during restart Dan Smith
     [not found] ` <1239039694-22332-1-git-send-email-danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-04-06 18:17   ` Serge E. Hallyn
     [not found]     ` <20090406181748.GA24751-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-04-14  5:59       ` Oren Laadan
     [not found]         ` <49E42646.4040703-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-04-14  6:05           ` Oren Laadan [this message]
     [not found]             ` <49E4278C.3060500-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-04-14 13:32               ` Dan Smith
     [not found]                 ` <87y6u3cqd0.fsf-FLMGYpZoEPULwtHQx/6qkW3U47Q5hpJU@public.gmane.org>
2009-04-14 14:40                   ` Oren Laadan
2009-05-14 16:10                   ` Oren Laadan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49E4278C.3060500@cs.columbia.edu \
    --to=orenl-eqauephvms7envbuuze7ea@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    --cc=serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.